- Notifications
You must be signed in to change notification settings - Fork2.5k
remote: add update_refs with git_refspec#6559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
38e3fd5
to0e7ab1c
Compare0e7ab1c
to9f53a5c
Compare9f53a5c
tofd28687
CompareAdd an `update_refs` callback that includes the refspec; `update_tips`is retained for backward compatibility.
fd28687
toc1b2b25
Compare1692d30
intomain 18 of 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This ABI-breaking change is not listed in the 1.9.0 release notes. Could it be added? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git
shows theremote andlocal ref information during a fetch. For example:This is not information that users of libgit2 can currently surface since our
update_tips
callback includes only src/dest OIDs, and thelocal ref name. Nor can one reliably reverse engineer the remote branch name, since a remote configuration could map two remote specs to a local spec. For example:In this case, given
refs/remotes/asdf/foo
in theupdate_tips
, a caller would have no idea whether the remote wasrefs/pull/foo/head
orrefs/heads/foo
.Provide the matching remote
git_refspec
so that callers canrtransform
themselves into the remote.