Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

checkout: make safe checkout the default#6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethomson merged 3 commits intomainfromethomson/checkout_safety
Oct 19, 2024

Conversation

ethomson
Copy link
Member

MakeGIT_CHECKOUT_SAFE the default.NONE is never what the user wantsby default; people expect checkout to, well, check things out. Instead, it should be an opt-in "dry run" mode.

But, in fact, it should be a dry run and fire notifications. So we keepDRY_RUN and remove theNONE mode entirely.

This removes some odd code in internal callers ofcheckout that takes agit_checkout_options and updates the mode toSAFE. This is now unnecessary since everything has better defaults.

@ethomsonethomsonforce-pushed theethomson/checkout_safety branch 3 times, most recently frome9b8db6 to03bd069CompareMarch 2, 2022 17:44
@ethomson
Copy link
MemberAuthor

I made some updates to remove the API breaking parts of these changes; this should be ABI breaking only.

@ethomsonethomsonforce-pushed theethomson/checkout_safety branch from03bd069 to09a51afCompareMarch 23, 2022 12:36
@ethomsonethomsonforce-pushed theethomson/checkout_safety branch from09a51af to6f7875bCompareOctober 19, 2024 12:09
@ethomsonethomsonforce-pushed theethomson/checkout_safety branch 2 times, most recently from54547f1 to165a748CompareOctober 19, 2024 21:33
Make `GIT_CHECKOUT_SAFE` the default.  `NONE` is never what the userwants _by default_; people expect checkout to, well, check things out.Instead, it should be an opt-in "dry run" mode.This removes some odd code in internal callers of `checkout` that takesa `git_checkout_options` and updates the mode to `SAFE`.  This is nowunnecessary since everything has better defaults.
Instead of dealing with the clone options sub-options (fetch, checkout,etc) individually, treat them as a cohesive whole when passing themthroughout the system.Additionally, move some functions around within the file to avoidunnecessary decls at the top of the file.  And change a functionsignature to avoid conflating truth with error.
@ethomsonethomsonforce-pushed theethomson/checkout_safety branch from165a748 to6955504CompareOctober 19, 2024 22:01
@ethomsonethomson merged commit68bffe4 intomainOct 19, 2024
18 of 19 checks passed
@ethomsonethomson deleted the ethomson/checkout_safety branchOctober 19, 2024 23:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@ethomson

[8]ページ先頭

©2009-2025 Movatter.jp