- Notifications
You must be signed in to change notification settings - Fork301
Clarify elem comment in jump_error_estimator#4356
Conversation
roystgnr commentedDec 18, 2025
If we have 2 elems with ids 10 and 11, we want a vector that will take indices 10 and 11. A vector of length 2 won't cut it. What prompted this PR? |
moosebuild commentedDec 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
lindsayad commentedDec 18, 2025
I read the comment and immediately surrounding code and figured that "resizing // Resize the error_per_cell vector to be// the number of elements, initialize it to 0. error_per_cell.resize (mesh.n_elem());std::fill (error_per_cell.begin(), error_per_cell.end(), 0.); |
roystgnr commentedDec 22, 2025
We've probably got line coverage but not feature coverage - we'd need to do adaptive coarsening while disabling renumbering to trigger a bug here, I think. |
lindsayad commentedDec 22, 2025
K I just changed the comment instead |
975d43b intolibMesh:develUh oh!
There was an error while loading.Please reload this page.
In
jump_error_estimator.C