Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Clarify elem comment in jump_error_estimator#4356

Merged
lindsayad merged 1 commit intolibMesh:develfrom
lindsayad:use-n-elem
Jan 5, 2026
Merged

Clarify elem comment in jump_error_estimator#4356
lindsayad merged 1 commit intolibMesh:develfrom
lindsayad:use-n-elem

Conversation

@lindsayad
Copy link
Member

Injump_error_estimator.C

@lindsayadlindsayad marked this pull request as ready for reviewDecember 18, 2025 01:20
@roystgnr
Copy link
Member

If we have 2 elems with ids 10 and 11, we want a vector that will take indices 10 and 11. A vector of length 2 won't cut it.

What prompted this PR?

@moosebuild
Copy link

moosebuild commentedDec 18, 2025
edited
Loading

JobCoverage, step Generate coverage on15ab5f1 wanted to post the following:

Coverage

61acf4#4356 15ab5f
TotalTotal+/-New
Rate65.27%65.27%-0.00%-
Hits7739977398-10
Misses4118541186+10

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@lindsayad
Copy link
MemberAuthor

If we have 2 elems with ids 10 and 11, we want a vector that will take indices 10 and 11. A vector of length 2 won't cut it.

What prompted this PR?

I read the comment and immediately surrounding code and figured that "resizingerror_per_cell vector to be the number of elements" would be a nice way to sync the comment and the code. I can see later on in the code that we index with ids so indeed this isn't a good change. But the fact that there are no issues in CIVET suggest there is no coverage of this code?

// Resize the error_per_cell vector to be// the number of elements, initialize it to 0.  error_per_cell.resize (mesh.n_elem());std::fill (error_per_cell.begin(), error_per_cell.end(), 0.);

@roystgnr
Copy link
Member

We've probably got line coverage but not feature coverage - we'd need to do adaptive coarsening while disabling renumbering to trigger a bug here, I think.

@lindsayadlindsayad changed the titleUse n_elem instead of max_elem_idClarify elem comment in jump_error_estimatorDec 22, 2025
@lindsayad
Copy link
MemberAuthor

K I just changed the comment instead

@lindsayadlindsayad merged commit975d43b intolibMesh:develJan 5, 2026
21 checks passed
@lindsayadlindsayad deleted the use-n-elem branchJanuary 5, 2026 19:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@roystgnrroystgnrroystgnr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lindsayad@roystgnr@moosebuild

[8]ページ先頭

©2009-2026 Movatter.jp