- Notifications
You must be signed in to change notification settings - Fork299
ExodusII_IO: if the mesh is renumbered then don't load solution vector data.#4341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
jwpeterson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This seems like a good addition to me, and I think we could do something similar inExodusII_IO::copy_elemental_solution(), which would have the same problem. I'm actually curious if any of our existing CI tests will hit this new error message.
As discussed in#4340, it would also be great to add a comment in the docs for this function, but I can tack that on later if you don't have the time.
faac5f8 to53115f2Comparedrwells commentedNov 24, 2025
Sounds good - I'll handle it! |
drwells commentedNov 24, 2025
Does this also apply to |
53115f2 to0e46c84Comparejwpeterson commentedNov 24, 2025
No, that one should not depend on the mesh reunumbering, it looks like we just match up the |
0e46c84 to012e632Compare| { | ||
| MeshTypemesh(*TestCommWorld); | ||
| mesh.allow_renumbering(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I haven't worked on libMesh's test suite before - I think this will fix the failing CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, I think this case worked before because the exo file we read in was already numbered the way libmesh liked it.
moosebuild commentedNov 24, 2025
4d68abd intolibMesh:develUh oh!
There was an error while loading.Please reload this page.
drwells commentedNov 24, 2025
Thanks for the help with this issue! |
Follow-up to#4340 - as a user, I'd rather set an additional flag then unknowingly load wrong nodal data.