Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit74b874d

Browse files
committed
package submission
1 parent35e888a commit74b874d

File tree

10 files changed

+41
-15
lines changed

10 files changed

+41
-15
lines changed

‎.Rbuildignore‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,7 @@
55
^_pkgdown\.yml$
66
^docs$
77
^pkgdown$
8-
^vignettes$
98
^cran-comments\.md$
9+
^CRAN-RELEASE$
10+
^doc$
11+
^Meta$

‎.gitignore‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,5 @@
44
.Ruserdata
55
skeleton.html
66
inst/doc
7+
doc
8+
Meta

‎CRAN-RELEASE‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
This package was submitted to CRAN on 2020-08-14.
2+
Once it is accepted, delete this file and tag the release (commit 35e888a).

‎DESCRIPTION‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
11
Package: getable
22
Type: Package
3-
Title:HTML Tables with DynamicData in R Markdown
4-
Version: 1.0.0
3+
Title:Fetching TabularData"Onload"inCompiledR Markdown HTML Documents
4+
Version: 1.0.2
55
Authors@R:
66
person(given = "Yongfu",
77
family = "Liao",
88
email = "liao961120@gmail.com",
99
role = c("aut", "cre"),
1010
comment = c(ORCID = "0000-0002-1814-2993"))
11-
Maintainer: Yongfu Liao <liao961120@gmail.com>
1211
Description: Dynamically retrieve data from the web to render HTML tables
1312
on inspection in R Markdown HTML documents.
14-
URL: https://yongfu.name/getable/, https://github.com/liao961120/getable
15-
BugReports: https://github.com/liao961120/getable/issues
13+
URL: https://yongfu.name/getable/, https://github.com/liao961120/getable/
14+
BugReports: https://github.com/liao961120/getable/issues/
1615
Depends: R (>= 3.4.0)
1716
License: MIT + file LICENSE
1817
Encoding: UTF-8

‎R/render.R‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,10 @@
2424
renderTable<-function(url="./data/df.csv",isjson=FALSE) {
2525

2626
# Update counter
27-
if (is.null(options()[['dataFromWebCounter']]))
28-
options('dataFromWebCounter'=1)
29-
else
30-
options('dataFromWebCounter'=1+ options()[['dataFromWebCounter']])
27+
.pkgenv[['dataFromWebCounter']]<-1+.pkgenv[['dataFromWebCounter']]
3128

3229
# div id for table
33-
id<- paste0('data-from-web-',options()[['dataFromWebCounter']])
30+
id<- paste0('data-from-web-',.pkgenv[['dataFromWebCounter']])
3431

3532
# Parse as google spreadsheet
3633
if (grepl('docs.google.com/spreadsheets/d/',url,fixed=T)) {

‎R/zzz.R‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
.pkgenv<- new.env(parent= emptyenv())
2+
3+
.onLoad<-function(libname,pkgname) {
4+
.pkgenv[['dataFromWebCounter']]<-0
5+
}

‎cran-comments.md‎

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,30 @@
1+
##Resubmission
2+
This is a resubmission. In this version I have:
3+
4+
* Remove the code that changes the user's options.
5+
6+
* Use package-global environment instead of
7+
the user's options to store variables used in
8+
the package.
9+
10+
111
##Test environments
212
- ubuntu 18.04 (local), R 3.6.3
3-
- win-builder (devel and release)
13+
- win-builder (devel: 2020-08-10 r79000 and
14+
release: R version 4.0.2)
415

516
##R CMD check results
6-
There were no ERRORs, WARNINGs, or NOTEs.
17+
There were 1 NOTE on win-builder:
18+
* checking CRAN incoming feasibility ... NOTE
19+
Maintainer: 'Yongfu Liao<liao961120@gmail.com>'
20+
21+
New submission
22+
23+
Possibly mis-spelled words in DESCRIPTION:
24+
Onload (3:31)
25+
26+
The possibly mis-spelled word "Onload" is correct.
27+
728

829
##Reverse Dependency Check
930
No ERRORs or WARNINGs found

‎inst/rmarkdown/templates/tablefromweb/skeleton/dfFromWeb.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ function createFromCSV(dom_id, url) {
4444

4545
// Create table from self-hosted json files
4646
functioncreateFromJSON(dom_id,url){
47-
// createFromJSON('new-table', './data/df.json');
48-
4947
// HTTP request
5048
axios({
5149
method:'get',

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp