Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(publish): replace +{SHA} with .{SHA} in lerna publish --canary#4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
MatusKnizka wants to merge2 commits intolerna:main
base:main
Choose a base branch
Loading
fromMatusKnizka:feature/dot-instead-of-plus

Conversation

@MatusKnizka
Copy link

@MatusKnizkaMatusKnizka commentedNov 15, 2024•
edited
Loading

Replace +{SHA} with .{SHA} in lerna publish --canary

Description

Instead of using plus (+) sign in package name provided by --canary flag, use dot.

Motivation and Context

It's not possible to publish --canary version into jfrog artifactory, as jfrog is cutting part of filename, due to + (plus) character. So, instead of using +, I would suggest to use dot.

#2060

How Has This Been Tested?

Unit tests
Integration tests
Run publish command

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read theCONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nx-cloud
Copy link

nx-cloudbot commentedFeb 19, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit64ae261.

CommandStatusDurationResult
nx run-many --t e2e --parallel=1✅ Succeeded3m 59sView ↗
nx run integration:integration --ci --maxWorkers=2✅ Succeeded3m 22sView ↗
nx run-many -t test --parallel=3 --ci --maxWork...✅ Succeeded44sView ↗
nx run-many -t lint --parallel=3✅ Succeeded18sView ↗
nx run-many -t build --parallel=3✅ Succeeded12sView ↗
nx-cloud record -- npx nx format:check✅ Succeeded3sView ↗
nx run-many -t build✅ Succeeded5sView ↗
nx run-many -t test --parallel=3 --ci --maxWork...✅ Succeeded1m 37sView ↗

☁️Nx Cloud last updated this comment at2025-02-19 15:28:18 UTC

@JamesHenry
Copy link
Member

I'm really sorry for the delay on a formal resolution here@MatusKnizka. This is not a PR we can proceed with directly because it's mixing a couple of different concerns IMO and is a breaking change which would required wider clean up.

The+ is significant in thesemver spec, it's called "build metadata":https://semver.org/#spec-item-10

Importantly, it is just metadata andnot used to differentiate versions during installs and dependency resolution:

1.0.0-alpha.0+abc123 and1.0.0-alpha.0+def456 willnot be treated any differently by your package manager - they are effectively the same version -1.0.0-alpha.0.

Therefore, it does make sense that jfrog is "cutting it" as you describe.

Please can you share more about your use-case? Are you trying to publish over the same version with different build metadata? Are you saying that lerna is not incrementing the.0 after the alpha upon subsequent canary releases?

Copy link
Member

@JamesHenryJamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

See comment

@JamesHenryJamesHenry marked this pull request as draftSeptember 15, 2025 13:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JamesHenryJamesHenryJamesHenry requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MatusKnizka@JamesHenry
[8]ページ先頭
©2009-2025 Movatter.jp