- Notifications
You must be signed in to change notification settings - Fork317
PermalinkChoose a base ref {{ refName }}default Choose a head ref {{ refName }}default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also orlearn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also.Learn more about diff comparisons here.
base repository:lektor/lektor
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
base:v3.4.0b7
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
...
head repository:lektor/lektor
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
Uh oh!
There was an error while loading.Please reload this page.
compare:v3.4.0b8
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}defaultLoading
- 2commits
- 10files changed
- 1contributor
Commits on Jun 6, 2023
Fix#908: Omit shadowed assets from build (#1147)
* test: add test to exercise#908* refactor(lektor.assets): present a single merged asset treeWhen themes are in use, assets can be located in one of multiple assetdirectories.Previously, in this case, we dealt with multiple asset roots, eachwith their own heirarchy of descendant assets. Some of thesedescendants can be shadowed by assets in one of the other asset roots,and should be ignored. This is difficult to manage.Here we refactor the code in `lektor.assets` to present a singlelogical merged asset tree which overlays the assets from the primaryproject `assets` directory with the `assets` directories of anythemes.* refactor(lektor.assets): be more careful about validating path components* refactor(lektor.assets): refactor Asset.resolve_url_pathThis cleans up the logic for detecting cases where the URL (or asset)name differs from the source file name. (There are cases where thesuffixes of the names can differ.)This disuses and deprecates the `from_url` parameter to`Asset.get_child`.* refactor(lektor.assets)!: remove vestigial method `Asset.build_asset``Asset.build_asset` is an undocumented no-op. It appears to beunreferenced by Lektor itself as well as all Lektor plugins that I'vebeen able to find.* tests(lektor.assets): enough annotations to get mypy to pass* tests(lektor.assets): increase test coverage* fix: do not Path.resolve() asset rootsThis was breaking the (imperfect) logic in`lektor.builder.PathCache.to_source_file` which checks that sourcefiles are contained within the project tree.* refactor(lektor.assets): cache child assets on DirectoryOptimization.Since Assets are tied to a Pad, the cache lifetime will match that ofthe Pad. This seems appropriate.
dairiki authoredJun 6, 2023 - dairiki committed
Jun 6, 2023
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff v3.4.0b7...v3.4.0b8
Uh oh!
There was an error while loading.Please reload this page.