Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add files field in package.json#8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
poppinlp wants to merge4 commits intoleetcode-tools:master
base:master
Choose a base branch
Loading
frompoppinlp:files_field
Open

Add files field in package.json#8

poppinlp wants to merge4 commits intoleetcode-tools:masterfrompoppinlp:files_field

Conversation

poppinlp
Copy link

As we mentionedhere. And some handy things.

  • Usefiles field to specify included files.
  • RemovepreferGlobal since it's deprecated.
  • Add more node version in.travis.yml.
  • Fix some lint errors inlib/plugins/cache.js.
  • Update.gitignore from gitignore repo.

@poppinlp
Copy link
Author

BTW. Looks like some test cases for plugins are broken in master branch. But I haven't look into it yet.
image

@jdneo
Copy link

Thank you@poppinlp

One nit is that there is no need to testNode.js on 4, 6 (the extension requires 8 at least)

@poppinlp
Copy link
Author

@jdneo OK. I'll fix it tonight. Sorry for my late reply. I'm in Vietnam recently.

@jdneojdneo requested a review fromVigilansApril 24, 2019 11:23
Copy link

@jasonchawjasonchaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good to me. 👍

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jasonchawjasonchawjasonchaw approved these changes

@VigilansVigilansAwaiting requested review from Vigilans

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@poppinlp@jdneo@jasonchaw
[8]ページ先頭
©2009-2025 Movatter.jp