Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

WIP: fetch problem tags from GraphQL & sort problems by natural order#51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
AerysNan wants to merge4 commits intoleetcode-tools:master
base:master
Choose a base branch
Loading
fromAerysNan:master

Conversation

AerysNan
Copy link

@AerysNanAerysNan commentedSep 11, 2020
edited
Loading

Here is thecorresponding issue.

Updates

  1. Fetch problem tags through GraphQL API instead of hardcoding them.
  2. Usenatural-orderBy to sort the problems by their frontend ID.

Problems

Currentlyvscode-leetcode relies onleetcode-cli's console output, which may restrict the scalability. Thoughleetcode-cli can fetch tags and store them in the cache,vscode-leetcode still cannot get them unless we output tag information to the console. But that would make the console message overwhelming.

  • So should we letvscode-leetcode visitleetcode-cli's cache file?

@AerysNan
Copy link
Author

Might need some suggestions.@yihong0618@jdneo

@yihong0618
Copy link

@AerysNan can we avoid usingnatural-orderBy package just write a function? And I think jdneo is a little busy, we can wait for him to review.

@AerysNan
Copy link
Author

@AerysNan can we avoid usingnatural-orderBy package just write a function? And I think jdneo is a little busy, we can wait for him to review.

Sure, I'll consider it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@AerysNan@yihong0618

[8]ページ先頭

©2009-2025 Movatter.jp