- Notifications
You must be signed in to change notification settings - Fork475
Refactor 2-cfg conditioning + better img-cfg defaults + support for DiT edit models#929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
stduhpf wants to merge5 commits intoleejet:masterChoose a base branch fromstduhpf:2-cond
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This helps make Inpaint or Pix2Pix models work nicely out of the box with cfg !=1 and unset img-cfg. The current implementation sets img_cfg = txt_cfg by default, but most inpaint/p2p models work best with img_cfg near 1.0, regardless of the txt_cfg value.
Should not affect the behavior of any other (non image conditionned) models hopefully.
While I'm at it, I added support for img-cfg in Flux Kontext and Qwen Image Edit models. It seems to have somewhat of an effect, though these models work just fine without it (especiallly Flux which doesn't handle any kind of cfg very well)
Also optimized sampling when txt_cfg==0. (Prompt is still processed in vain, but at least it's not used during sampling anymore)