- Notifications
You must be signed in to change notification settings - Fork472
feat: add KL Optimal scheduler#1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
wbruna commentedDec 15, 2025
LGTM, and seems to be working fine.
I don't know if that order matters much. When I implemented the LCM scheduler, I simply placed it at the end of the list. |
daniandtheweb commentedDec 17, 2025
I was actually thinking about the order of the schedulers based on importance: of course the first would be discrete and karras as they're historically the most used and last should be LCM as it's more like a niche scheduler for a single specific application. I'm really not sure where kl_optimal should be placed compared to all the others, but if it's okay like this I think the PR is ready. |
Uh oh!
There was an error while loading.Please reload this page.
This PR adds support for the KL Optimal scheduler.
I've taken inspiration from the Python implementation in ComfyUI and stable-diffusion-webui.
The resulting images seem correct. If the positioning of the scheduler looks good (after smoothstep and before lcm), I think this could be ready to review.