Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Child workflow signaling#290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rmcdaniel wants to merge5 commits intomaster
base:master
Choose a base branch
Loading
fromfeature/child-workflow-signaling

Conversation

@rmcdaniel
Copy link
Contributor

This PR introduces a safe mechanism for parent workflows to signal their children through two new features:

1. ChildWorkflowHandle Class

A newChildWorkflowHandle class that wraps a child workflow and provides context-safe signaling:

  • Context Preservation: Automatically saves and restores parent workflow context when forwarding signals to children
  • Replay Safety: Skips re-signaling during workflow replay to avoid duplicate signals
  • Simple API: Uses__call() magic method to forward any signal method to the child

2. Workflow Methods:child() andchildren()

Two new methods added to the baseWorkflow class:

  • child(): Returns aChildWorkflowHandle for the most recently created child workflow at the current execution index
  • children(): Returns an array ofChildWorkflowHandle instances for all child workflows at the current execution index

Both methods aredeterministic - they filter children byparent_index <= $this->index, ensuring consistent results during workflow replay.

Usage Examples

Example 1: Parent Directly Signals Child

publicfunctionexecute(){// Start child (don't yield yet)$childPromise = ChildWorkflowStub::make(ChildWorkflow::class,'arg');// Get handle and signal child$childHandle =$this->child();$childHandle->approve('approved');// Wait for child to complete$result =yield$childPromise;return$result;}

Example 2: Parent Forwards External Signal to Child

class ParentWorkflowextends Workflow{privatebool$receivedSignal =false;private ?string$signalData =null;    #[SignalMethod]publicfunctionexternalSignal(string$data):void    {$this->receivedSignal =true;$this->signalData =$data;    }publicfunctionexecute()    {// Start child$childPromise = ChildWorkflowStub::make(ChildWorkflow::class);// Get child handle (called once in execute, saved to local variable)$childHandle =$this->child();// Wait for external signalyield WorkflowStub::await(fn () =>$this->receivedSignal);// Forward signal to child using saved handleif ($childHandle &&$this->signalData) {$childHandle->processData($this->signalData);        }// Wait for child completion$result =yield$childPromise;return$result;    }}

@codecov
Copy link

codecovbot commentedNov 30, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (57b9c08) to head (bc4feec).

Additional details and impacted files
@@             Coverage Diff             @@##              master      #290   +/-   ##===========================================  Coverage     100.00%   100.00%- Complexity       316       323    +7===========================================  Files             46        47    +1       Lines           1327      1355   +28     ===========================================+ Hits            1327      1355   +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This comment was marked as resolved.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmcdaniel

[8]ページ先頭

©2009-2025 Movatter.jp