Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork60
Child workflow signaling#290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
rmcdaniel wants to merge5 commits intomasterChoose a base branch fromfeature/child-workflow-signaling
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+637 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedNov 30, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #290 +/- ##=========================================== Coverage 100.00% 100.00%- Complexity 316 323 +7=========================================== Files 46 47 +1 Lines 1327 1355 +28 ===========================================+ Hits 1327 1355 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a safe mechanism for parent workflows to signal their children through two new features:
1. ChildWorkflowHandle Class
A new
ChildWorkflowHandleclass that wraps a child workflow and provides context-safe signaling:__call()magic method to forward any signal method to the child2. Workflow Methods:
child()andchildren()Two new methods added to the base
Workflowclass:child(): Returns aChildWorkflowHandlefor the most recently created child workflow at the current execution indexchildren(): Returns an array ofChildWorkflowHandleinstances for all child workflows at the current execution indexBoth methods aredeterministic - they filter children by
parent_index <= $this->index, ensuring consistent results during workflow replay.Usage Examples
Example 1: Parent Directly Signals Child
Example 2: Parent Forwards External Signal to Child