NotificationsYou must be signed in to change notification settings
Fork11.7k
Star34.4k

[12.x] Fix AppendableAttributeValue escape string value#58168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

basantashubhu wants to merge2 commits intolaravel:12.x

base:12.x

Choose a base branch

frombasantashubhu:12.x

Open

[12.x] Fix AppendableAttributeValue escape string value#58168

basantashubhu wants to merge2 commits intolaravel:12.xfrombasantashubhu:12.x

+22 −4

Conversation

Copy link

basantashubhu commentedDec 19, 2025

Issue: AppendableAttributeValue did not escape the string value at first.

Fix: The fix is simple escape the string at the begining not while resolving.

$attributeDefaults = array_map(function ($value) use ($escape) {    if($value instanceof AppendableAttributeValue) {        return new AppendableAttributeValue(            $this->resolveAppendableAttributeDefault([$value], 0, $escape)        );    }    return $this->shouldEscapeAttributeValue($escape, $value)        ? e($value)        : $value;});