- Notifications
You must be signed in to change notification settings - Fork11.7k
[12.x] Pause a queue for given seconds#57917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
9538b23 intolaravel:12.x 74 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR#57800 added the
QueueManager@pause()method to allow pausing a given queue.This method pauses the queue indefinitely by using a cache's store
forever()method.As such a queue can only be resumed by calling the
QueueManager@resume()method added in the same PR.When consuming an external API with rate limiting, one can get a
429response when the rate limit is surpassed.Often times this response is accompanied by the
Retry-Afterheader that gives the number of seconds to wait before retrying.Currently, one would need to keep track of those seconds to manually pause a queue (when a
429response is received) and manually resume a queue (when the timeout is expired).This PR
QueueManager@pauseFor()method that allows passing the number of seconds a queue should be paused.$secondsargument.