- Notifications
You must be signed in to change notification settings - Fork11.7k
[12.x] Fix flaky test in ArraySessionHandler (garbage collection)#57904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
taylorotwell merged 1 commit intolaravel:12.xfromsumaiazaman:fix-flaky-array-session-handler-test-3Nov 25, 2025
Merged
[12.x] Fix flaky test in ArraySessionHandler (garbage collection)#57904
taylorotwell merged 1 commit intolaravel:12.xfromsumaiazaman:fix-flaky-array-session-handler-test-3Nov 25, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This prevents timing race conditions where time can advance betweenwhen the session is written (which records a timestamp) and whenthe garbage collection check occurs, causing intermittent test failures.
6ec8614 intolaravel:12.x 76 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaky test by freezing time before the write operation in
test_it_cleans_up_old_sessions.Problem:
Without freezing time, there's a small window where time can advance between when the session is written (which records a timestamp) and when the garbage collection check occurs. This can cause the test to fail intermittently.
Solution:
Add
Carbon::setTestNow(Carbon::now());before the firstwrite()operation to ensure consistent timing throughout the test.Related:
This follows the same pattern as#57864.