Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[12.x] PHP 8.5 Compatibility#57835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
taylorotwell merged 31 commits into12.xfrom12/php85-1
Nov 21, 2025
Merged

[12.x] PHP 8.5 Compatibility#57835

taylorotwell merged 31 commits into12.xfrom12/php85-1
Nov 21, 2025

Conversation

@crynobone
Copy link
Member

@crynobonecrynobone commentedNov 20, 2025•
edited
Loading

  • Redis PHP extension
  • Memcached PHP extension

datlechin, realodix, MSufianS, kolydart, and nbreens reacted with thumbs up emojiyabooodya reacted with confused emoji
crynoboneand others added15 commitsNovember 20, 2025 09:08
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobonecrynobone marked this pull request as ready for reviewNovember 20, 2025 03:36
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@browner12
Copy link
Contributor

would it make more sense to use something likeversion_compare(PHP_VERSION, '8.4.0', '>=') to more consistent with other version checking in the FW? this would be the first use of thePHP_VERSION_ID constant in the codebase.

@crynobonecrynobone marked this pull request as draftNovember 20, 2025 07:28
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone
Copy link
MemberAuthor

crynobone commentedNov 20, 2025•
edited
Loading

@browner12 The constant is temporarily used untilsymfony/polyfill#549 gets merged.

We hope it will be available before PHP 8.5.0 stable release is available but we need to prepare all our 1st party packages right now.

@crynobonecrynobone marked this pull request as ready for reviewNovember 20, 2025 08:39
@browner12
Copy link
Contributor

yah, I wasn't suggesting not checking the version. I was just suggesting to stay consistent with other version checking in the FW and switch:

PHP_VERSION_ID >=80500;

to

version_compare(phpversion(),'8.5.0','>=');

if you don't expect this code to stay in long, I guess I'm indifferent, but if it'll be in there a bit would be nice to stay consistent.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crynobone@browner12@taylorotwell@StyleCIBot
[8]ページ先頭
©2009-2025 Movatter.jp