- Notifications
You must be signed in to change notification settings - Fork11.7k
[12.x] Run tests on PHP 8.5#57231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
jnoordsij wants to merge2 commits intolaravel:12.xChoose a base branch
base:12.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
With the first RC now available (seehttps://www.php.net/archive/2025.php#2025-09-25-3), keeping track of PHP 8.5 support in the test suite is probably worthwhile.
Draft until passing, fixes should probably be addressed in individual PRs.
Observed issues:
[13.x] Replace __wakeup with __unserialize (deprecated in PHP 8.5) #57032 Replace __wakeup with __unserialize (deprecated in PHP 8.5)PHP Warning: unexpected NAN value was coerced to string in /home/runner/work/framework/framework/vendor/sebastian/exporter/src/Exporter.php on line 354(and similar messages)51) /home/runner/work/framework/framework/src/Illuminate/Queue/Worker.php:366 Using null as an array offset is deprecated, use an empty string insteadObserved deprecations from dependencies:
/home/runner/work/framework/framework/vendor/opis/json-schema/src/SchemaLoader.php:245 Method SplObjectStorage::contains() is deprecated since 8.5, use method SplObjectStorage::offsetExists() instead