Movatterモバイル変換

Skip to content

laravel/frameworkPublic

NotificationsYou must be signed in to change notification settings
Fork11.4k
Star33.8k

[12.x] Fix incorrect return types and handle NumberFormatter failure in Number class#55957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft

platoindebugmode wants to merge1 commit intolaravel:12.x

base:12.x

Choose a base branch

fromplatoindebugmode:fix/number-return-types

Draft

[12.x] Fix incorrect return types and handle NumberFormatter failure in Number class#55957

platoindebugmode wants to merge1 commit intolaravel:12.xfromplatoindebugmode:fix/number-return-types

+10 −10

Conversation

platoindebugmode

Copy link

Contributor

platoindebugmode commentedJun 8, 2025

This PR updates the Number class to:

Correct the return types of parse(), parseInt(), and parseFloat() to include false.
Add return types for spell(), ordinal(), and spellOrdinal() methods.
Handle false return values from NumberFormatter::format() by falling back to (string) $number.

No breaking changes introduced, only enhances type accuracy and guards against silent false values.

@platoindebugmode

add accurate return types and handle false from NumberFormatter

c45ae46

@shaedrich

Copy link

Contributor

shaedrich commentedJun 9, 2025

Adding a return type hintis a breaking change. Therefore, you should targetmaster

@taylorotwell

taylorotwell marked this pull request as draft

June 9, 2025 14:09

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

2 participants

@platoindebugmode

@shaedrich

[8]ページ先頭

©2009-2025 Movatter.jp