- Notifications
You must be signed in to change notification settings - Fork11.4k
skip appending page=1 in pagination URLs#55772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
safaeean wants to merge1 commit intolaravel:12.xChoose a base branch
base:12.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+11 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
feat(pagination): omit ?page=1 and prevent dangling separatorsSkip adding the `page` query parameter when the requested page equals 1,returning the canonical base path instead.When no extra query parameters are present, the function now suppressesthe `?` / `&` separator entirely. This prevents URLs such as`/users?` or `/users&` and avoids duplicate‑content issues for the firstpage.Behaviour for pages >1 and for existing custom query strings isunchanged.
Mark as draft since test are failing. |
Comment on lines +199 to +206
| // Build the query string and attach it to the path | ||
| $query = Arr::query($parameters); | ||
| return $this->path() | ||
| .(str_contains($this->path(), '?') ? '&' : '?') | ||
| .Arr::query($parameters) | ||
| .$this->buildFragment(); | ||
| . ($query === '' | ||
| ? '' | ||
| : (str_contains($this->path(), '?') ? '&' : '?') . $query) | ||
| . $this->buildFragment(); |
Contributor
shaedrichMay 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You might just use theUri class here:
Suggested change
| // Build the query string and attach it to the path | |
| $query = Arr::query($parameters); | |
| return$this->path() | |
| .(str_contains($this->path(),'?') ?'&' :'?') | |
| .Arr::query($parameters) | |
| .$this->buildFragment(); | |
| . ($query ==='' | |
| ?'' | |
| : (str_contains($this->path(),'?') ?'&' :'?') .$query) | |
| .$this->buildFragment(); | |
| return Uri::of($this->path())->withQuery($query)->withFragment($this->buildFragment); |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(pagination): omit ?page=1 and prevent dangling separators
Skip adding the
pagequery parameter when the requested page equals 1, returning the canonical base path instead.When no extra query parameters are present, the function now suppresses the
?/&separator entirely. This prevents URLs such as/users?or/users&and avoids duplicate‑content issues for the first page.Behaviour for pages >1 and for existing custom query strings is unchanged.