- Notifications
You must be signed in to change notification settings - Fork11.4k
[12.x] AddsEagerLoad attribute andinitializeOnQueue hook#55590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:12.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
WithRelations attributeI'm sure you're already on it, but the class name is still |
Uh oh!
There was an error while loading.Please reload this page.
WithRelations attributeLoadRelations attributeLoadRelations attributeLoadRelations and initilizer hooks on on the queueLoadRelations and initilizer hooks on on the queueEagerLoad attribute andinitializeOnQueue hook| } | ||
| } | ||
| if (in_array(Queueable::class, class_uses_recursive($this)) && method_exists($this, 'initializeOnQueue')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I feel like swapping the order would be more optimal, but probably not by much:
if (method_exists($this,'initializeOnQueue') &&in_array(Queueable::class,class_uses_recursive($this))) {
Probably would only be important if this was called a lot.
No description provided.