- Notifications
You must be signed in to change notification settings - Fork11.7k
Why is tinker in require and not require-dev?#58131
-
Code that should not be run in production is useless overhead in production. From here the question. Thank you. |
BetaWas this translation helpful?Give feedback.
All reactions
Replies: 2 comments 9 replies
-
Well, I love that I can run code in production when I can only debug it there. I don't have to deploy a patch and hope for the best. |
BetaWas this translation helpful?Give feedback.
All reactions
-
Is that worth the fact that for each request its service provider is called and the class map gets bigger with it and its dependencies? |
BetaWas this translation helpful?Give feedback.
All reactions
-
Maybe, the service provider can only be called when needed. That's the actual problem here. |
BetaWas this translation helpful?Give feedback.
All reactions
-
It has autodiscovery in its composer.json so you would need to manually register it on local and alter its composer.json to register it manually. Anyway thank you. From my point of view it belongs to require-dev and it can be moved there in each project (template). |
BetaWas this translation helpful?Give feedback.
All reactions
-
Hmmm... where exactly is it defined as a require and not a require-dev? |
BetaWas this translation helpful?Give feedback.
All reactions
-
I looked in the composer.json of this repo (the framework) and it is shown only as a suggestion and not a require. So which template exactly? |
BetaWas this translation helpful?Give feedback.
All reactions
-
This repo is the kernel not the template that requires it. |
BetaWas this translation helpful?Give feedback.
All reactions
-
https://github.com/laravel/laravel/blob/ad4ca3e9a02ed4104f8a42657219fdbe199462eb/composer.json#L11 |
BetaWas this translation helpful?Give feedback.
All reactions
-
Why not make a Pull Request to move it to require-dev? |
BetaWas this translation helpful?Give feedback.
All reactions
-
Because I did that for my own project without the risk of upseting anyone by doing so :). You know that the power of defaults is big. |
BetaWas this translation helpful?Give feedback.