- Notifications
You must be signed in to change notification settings - Fork19.3k
Fix config propagation in AgentExecutor#33332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Fix config propagation in AgentExecutor#33332
Conversation
@baskaryan I am not aware who maintains this repo , please add a reviewer for this fix |
@aroun-coumar you'll need to rebase against as langchain is now in langchain-classic. We can review this PR. I think there have been previous attempts to make this fix, but those were wrong. AgentExecutor was introduced before there was a concept of a config, and I think that there was no easy way to accommodate it. We're recommending that most users change to the langchain prebuilt agent. https://docs.langchain.com/oss/python/langchain/overview -- this is avaliable as part of the alpha release, and will be available officialy as part of the 1.0 release |
…hain by adding config parameter, ensure_config, and updating docstrings (# config fix)
b60ad91 to9b6ce34CompareHi@eyurtsev , I have rebased my codebase as suggested, i got few failing checks in CI which i would resolve ASAP (any support welcomed) I locally tested my changes and now the config is passed correctly for both cases mentioned in the bug, |
Since i changed the signature of _call and _acall in base.py we may have to change(add config param) all those files which uses _call and _acall in chain |
This PR is a fix for the bug mentioned in33080