- Notifications
You must be signed in to change notification settings - Fork22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Members initialization in AssociationParameters#40
base:master
Are you sure you want to change the base?
Conversation
…here some members could have garbage values.
coveralls commentedOct 19, 2016
Sadly, I can't merge this yet: I still need to support Ubuntu 12.04 and its GCC 4.6, which does not have in-class initializers. I'll leave this PR open for now, since the official support (and hence Odil's support) will end at in March 2017. |
At least we should fix the bug of |
Initialization is fixed inb3d1518 while waiting for Ubuntu 12.04 to be end-of-life. |
@lamyj do you think this one could be merged? |
There are currently 3 constructors for AssociationParameters, but not all initialize all the class members.
We can factor using class member initializers.
Also, calling default constructors for members is not necessary.