Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit6dfea76

Browse files
authored
fix: client telemetry attribute names (#321)
1 parent36665ae commit6dfea76

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

‎src/main/java/io/kurrent/dbclient/ClientTelemetry.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ static CompletableFuture<WriteResult> traceAppend(
9494
SpanKind.CLIENT,
9595
null,
9696
ClientTelemetryTags.builder()
97-
.withRequiredTag(ClientTelemetryAttributes.Kurrent.STREAM,streamId)
97+
.withRequiredTag(ClientTelemetryAttributes.KurrentDB.STREAM,streamId)
9898
.withServerTagsFromGrpcChannel(channel)
9999
.withServerTagsFromClientSettings(settings)
100100
.withOptionalDatabaseUserTag(settings.getDefaultCredentials())
@@ -139,10 +139,10 @@ static void traceSubscribe(Runnable tracedOperation, String subscriptionId, Mana
139139
SpanKind.CONSUMER,
140140
remoteParentContext,
141141
ClientTelemetryTags.builder()
142-
.withRequiredTag(ClientTelemetryAttributes.Kurrent.STREAM,event.getStreamId())
143-
.withRequiredTag(ClientTelemetryAttributes.Kurrent.SUBSCRIPTION_ID,subscriptionId)
144-
.withRequiredTag(ClientTelemetryAttributes.Kurrent.EVENT_ID,event.getEventId().toString())
145-
.withRequiredTag(ClientTelemetryAttributes.Kurrent.EVENT_TYPE,event.getEventType())
142+
.withRequiredTag(ClientTelemetryAttributes.KurrentDB.STREAM,event.getStreamId())
143+
.withRequiredTag(ClientTelemetryAttributes.KurrentDB.SUBSCRIPTION_ID,subscriptionId)
144+
.withRequiredTag(ClientTelemetryAttributes.KurrentDB.EVENT_ID,event.getEventId().toString())
145+
.withRequiredTag(ClientTelemetryAttributes.KurrentDB.EVENT_TYPE,event.getEventType())
146146
.withServerTagsFromGrpcChannel(channel)
147147
.withServerTagsFromClientSettings(settings)
148148
.withOptionalDatabaseUserTag(settings.getDefaultCredentials())

‎src/main/java/io/kurrent/dbclient/ClientTelemetryAttributes.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ public static class Exceptions {
2222
publicstaticfinalStringSTACK_TRACE =ExceptionAttributes.EXCEPTION_STACKTRACE.getKey();
2323
}
2424

25-
publicstaticclassKurrent {
26-
publicstaticfinalStringSTREAM ="db.kurrent.stream";
27-
publicstaticfinalStringSUBSCRIPTION_ID ="db.kurrent.subscription.id";
28-
publicstaticfinalStringEVENT_ID ="db.kurrent.event.id";
29-
publicstaticfinalStringEVENT_TYPE ="db.kurrent.event.type";
25+
publicstaticclassKurrentDB {
26+
publicstaticfinalStringSTREAM ="db.kurrentdb.stream";
27+
publicstaticfinalStringSUBSCRIPTION_ID ="db.kurrentdb.subscription.id";
28+
publicstaticfinalStringEVENT_ID ="db.kurrentdb.event.id";
29+
publicstaticfinalStringEVENT_TYPE ="db.kurrentdb.event.type";
3030
}
3131
}

‎src/main/java/io/kurrent/dbclient/ClientTelemetryConstants.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
packageio.kurrent.dbclient;
22

33
publicclassClientTelemetryConstants {
4-
publicstaticfinalStringINSTRUMENTATION_NAME ="kurrent";
4+
publicstaticfinalStringINSTRUMENTATION_NAME ="kurrentdb";
55

66
publicstaticclassMetadata {
77
publicstaticfinalStringTRACE_ID ="$traceId";

‎src/test/java/io/kurrent/dbclient/telemetry/TelemetryAware.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public interface TelemetryAware extends ConnectionAware {
2121
defaultvoidassertAppendSpanHasExpectedAttributes(ReadableSpanspan,StringstreamName) {
2222
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Database.SYSTEM,ClientTelemetryConstants.INSTRUMENTATION_NAME);
2323
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Database.OPERATION,ClientTelemetryConstants.Operations.APPEND);
24-
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Kurrent.STREAM,streamName);
24+
assertSpanAttributeEquals(span,ClientTelemetryAttributes.KurrentDB.STREAM,streamName);
2525
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Database.USER,"admin");
2626
Assertions.assertEquals(StatusCode.OK,span.toSpanData().getStatus().getStatusCode());
2727
Assertions.assertEquals(SpanKind.CLIENT,span.getKind());
@@ -42,10 +42,10 @@ default void assertSubscriptionActivityHasExpectedAttributes(ReadableSpan span,
4242
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Database.SYSTEM,ClientTelemetryConstants.INSTRUMENTATION_NAME);
4343
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Database.OPERATION,ClientTelemetryConstants.Operations.SUBSCRIBE);
4444
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Database.USER,"admin");
45-
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Kurrent.STREAM,streamName);
46-
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Kurrent.SUBSCRIPTION_ID,subscriptionId);
47-
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Kurrent.EVENT_ID,eventId);
48-
assertSpanAttributeEquals(span,ClientTelemetryAttributes.Kurrent.EVENT_TYPE,eventType);
45+
assertSpanAttributeEquals(span,ClientTelemetryAttributes.KurrentDB.STREAM,streamName);
46+
assertSpanAttributeEquals(span,ClientTelemetryAttributes.KurrentDB.SUBSCRIPTION_ID,subscriptionId);
47+
assertSpanAttributeEquals(span,ClientTelemetryAttributes.KurrentDB.EVENT_ID,eventId);
48+
assertSpanAttributeEquals(span,ClientTelemetryAttributes.KurrentDB.EVENT_TYPE,eventType);
4949
Assertions.assertEquals(StatusCode.OK,span.toSpanData().getStatus().getStatusCode());
5050
Assertions.assertEquals(SpanKind.CONSUMER,span.getKind());
5151
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp