Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support dict[...] syntax in ApiClient.__deserialize#2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mohsinm-dev wants to merge1 commit intokubernetes-client:master
base:master
Choose a base branch
Loading
frommohsinm-dev:fix-dict-syntax-support

Conversation

@mohsinm-dev
Copy link

Summary

  • Adds support for moderndict[str, str] syntax inApiClient.__deserialize()
  • Maintains backward compatibility with existingdict(str, str) syntax
  • Enables Pydantic adapter compatibility foropenapi_types

Changes

  • Added post-generation patchscripts/api_client_dict_syntax.diff
  • Updatedscripts/update-client.sh to apply patch during client generation
  • Added comprehensive unit tests covering both syntaxes and nested dicts

Test plan

  • Unit testtest_deserialize_dict_syntax_compatibility passes
  • Legacydict(str, str) syntax continues to work
  • Newdict[str, str] syntax works correctly
  • Nesteddict[str, dict[str, str]] syntax works
  • No breaking changes to existing functionality

Fixes#2463

…upport)Adds post-gen patch; aligns with list[...] and pydantic adapters; no behavior change for legacy types.Fixeskubernetes-client#2463
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow ourrelease note process to remove it.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@k8s-ci-robotk8s-ci-robot added do-not-merge/invalid-commit-messageIndicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels. labelsNov 1, 2025
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 1a3a022 client: accept dict[...] in ApiClient.__deserialize (keep dict(...) support)

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository. I understand the commands that are listedhere.

@k8s-ci-robotk8s-ci-robot added cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. needs-kindIndicates a PR lacks a `kind/foo` label and requires one. labelsNov 1, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:mohsinm-dev
Once this PR has been reviewed and has the lgtm label, please assignyliaog for approval. For more information seethe Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added the size/MDenotes a PR that changes 30-99 lines, ignoring generated files. labelNov 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw

@yliaogyliaogAwaiting requested review from yliaog

Assignees

No one assigned

Labels

cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.do-not-merge/invalid-commit-messageIndicates that a PR should not merge because it has an invalid commit message.do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels.needs-kindIndicates a PR lacks a `kind/foo` label and requires one.size/MDenotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect type declaration inopenapi_types fordict

2 participants

@mohsinm-dev@k8s-ci-robot
[8]ページ先頭
©2009-2025 Movatter.jp