- Notifications
You must be signed in to change notification settings - Fork3.4k
Set an upper limit on the urllib3 dependency#2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
With urllib3 2.4.0 stricter certificate validity checks were added when runningon Python 3.13+:urllib3/urllib3#3571.This triggers errors such as the following:> [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Missing Authority> Key IdentifierIt is however only for users with Kubernetes clusters that have been set upwithout proper, valid certificates. Notably, this was the case for AWS EKSclusters created with Kubernetes v1.16 and earlier.
[APPROVALNOTIFIER] This PR isNOT APPROVED This pull-request has been approved by:Tenzer The full list of commands accepted by this bot can be foundhere. Needs approval from an approver in each of these files: Approvers can indicate their approval by writing |
Welcome@Tenzer! |
The test failure is courtesy of#2406. Should I fix it in this PR by fixing the syntax in |
Yes, please. Thanks. |
/assign@yliaog |
What type of PR is this?
/kind bug
What this PR does / why we need it:
With urllib3 2.4.0 stricter certificate validity checks were added when running on Python 3.13+:urllib3/urllib3#3571.
This triggers errors such as the following:
It is however only for users with Kubernetes clusters that have been set up without proper, valid certificates. Notably, this was the case for AWS EKS clusters created with Kubernetes v1.16 and earlier.
Which issue(s) this PR fixes:
Fixes#2394
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: