NotificationsYou must be signed in to change notification settings
Fork3.4k
Star7.2k

feat: populate cluster config from client.authentication.k8s.io/exec …#2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

ma-ts wants to merge1 commit intokubernetes-client:master

base:master

Choose a base branch

fromma-ts:master

Open

feat: populate cluster config from client.authentication.k8s.io/exec …#2399

ma-ts wants to merge1 commit intokubernetes-client:masterfromma-ts:master

Conversation

Copy link

ma-ts commentedMay 27, 2025•
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

populateExecCredentialSpec.Cluster.config from the client.authentication.k8s.io/exec extension

Which issue(s) this PR fixes:

Fixes#2395

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds cluster config information to the exec credential provider if the client.authentication.k8s.io/exec extension is provided.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Recreating PR since#2396 has CLA issues. Credits go to@wkloucek

feat: populate cluster config from client.authentication.k8s.io/exec …

ee35f6b

…extension

k8s-ci-robot added kind/bug

Categorizes issue or PR as related to a bug.

do-not-merge/release-note-label-needed

Indicates that a PR should not merge because it's missing one of the release note labels.

cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. labels

May 27, 2025

Copy link

Contributor

k8s-ci-robot commentedMay 27, 2025

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:ma-ts
Once this PR has been reviewed and has the lgtm label, please assignroycaihw for approval. For more information seethe Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

kubernetes/base/OWNERS

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

Copy link

Contributor

k8s-ci-robot commentedMay 27, 2025

Welcome@ma-ts!

It looks like this is your first PR tokubernetes-client/python 🎉. Please refer to ourpull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment.Here is the bot commands documentation.

You can also check if kubernetes-client/python hasits own contribution guidelines.

You may want to refer to ourtesting guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow therecommended escalation practices. Also, for tips and tricks in the contribution process you may want to read theKubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot requested review fromfabianvf andyliaog

May 27, 2025 18:08

k8s-ci-robot added size/M

Denotes a PR that changes 30-99 lines, ignoring generated files.

release-noteDenotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels. labels

May 27, 2025

Copy link

Author

ma-ts commentedMay 31, 2025

@fabianfv @yliaog Any comments about this PR? Would be nice if we can release this, so that clusters using these extensions can be managed with this library.

Also fixes some big issues on the Azure CLI managing these clusters from Azure.