Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

populate cluster config from client.authentication.k8s.io/exec extension#2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

wkloucek
Copy link

@wkloucekwkloucek commentedMay 14, 2025•
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

populateExecCredentialSpec.Cluster.config from theclient.authentication.k8s.io/exec extension

Which issue(s) this PR fixes:

Fixes#2395

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds cluster config information to the exec credential provider if the client.authentication.k8s.io/exec extension is provided.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robotk8s-ci-robot added release-note-noneDenotes a PR that doesn't merit a release note. kind/bugCategorizes issue or PR as related to a bug. labelsMay 14, 2025
@linux-foundation-easyclaLinux Foundation: EasyCLA
Copy link

linux-foundation-easyclabot commentedMay 14, 2025•
edited
Loading

CLA Not Signed

@k8s-ci-robotk8s-ci-robot added the cncf-cla: noIndicates the PR's author has not signed the CNCF CLA. labelMay 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:wkloucek
Once this PR has been reviewed and has the lgtm label, please assignroycaihw for approval. For more information seethe Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome@wkloucek!

It looks like this is your first PR tokubernetes-client/python 🎉. Please refer to ourpull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment.Here is the bot commands documentation.

You can also check if kubernetes-client/python hasits own contribution guidelines.

You may want to refer to ourtesting guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow therecommended escalation practices. Also, for tips and tricks in the contribution process you may want to read theKubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robotk8s-ci-robot added size/XSDenotes a PR that changes 0-9 lines, ignoring generated files. release-noteDenotes a PR that will be considered when it comes time to generate release notes. and removed release-note-noneDenotes a PR that doesn't merit a release note. labelsMay 14, 2025
@roycaihw
Copy link
Member

Please sign the CLA. Also please add a unit test for this.

@k8s-ci-robotk8s-ci-robot added size/MDenotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XSDenotes a PR that changes 0-9 lines, ignoring generated files. labelsMay 19, 2025
@ma-ts
Copy link

ma-ts commentedMay 24, 2025•
edited
Loading

Hi! Can this be implemented?@wkloucek: if the CLA is prohibited by your organisation, more than happy to re-contribute from our organisation.

Merging this also fixes issues with the Azure CLI, connecting on-prem clusters to Azure (seeAzure/azure-cli-extensions#8788).

Validated that this fixes the issue there as well (by patching the function call manually)

@wkloucek
Copy link
Author

Hi! Can this be implemented?@wkloucek: if the CLA is prohibited by your organisation, more than happy to re-contribute from our organisation.

I'm currently waiting for my company to register for the CLA. I didn't hear back how long it's gonna take though

@ma-ts
Copy link

Can I republish? More than happy to give you all credits

@wkloucek
Copy link
Author

Unfortunately, I couldn't get the CLA setup so far. Also meanwhile this is not needed any longer on my side.

@ma-ts already picked those changes up in#2399, therefore I'm gonna close here

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabianvffabianvfAwaiting requested review from fabianvf

@roycaihwroycaihwAwaiting requested review from roycaihw

Assignees
No one assigned
Labels
cncf-cla: noIndicates the PR's author has not signed the CNCF CLA.kind/bugCategorizes issue or PR as related to a bug.release-noteDenotes a PR that will be considered when it comes time to generate release notes.size/MDenotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExecCredentialSpec.Cluster. config is missing
4 participants
@wkloucek@k8s-ci-robot@roycaihw@ma-ts
[8]ページ先頭
©2009-2025 Movatter.jp