Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update to examples/yaml_dir/nginx-deployment.#2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Rudra990 wants to merge1 commit intokubernetes-client:master
base:master
Choose a base branch
Loading
fromRudra990:master

Conversation

Rudra990
Copy link

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR improves the Nginx deployment by:

Increasing replicas from 3 to 5 for better load balancing and availability.
Updating the Nginx image from 1.15.4 to 1.23.3, ensuring better security, performance, and fewer bugs.
Adding a Liveness Probe to automatically restart the app if it crashes.
Adding a Readiness Probe to ensure the app is fully ready before receiving traffic.
Setting Resource Limits to control CPU and RAM usage, preventing excessive resource consumption.
Introducing Environment Variables for dynamic configuration, allowing settings like WELCOME_MESSAGE to be customized easily.
Which issue(s) this PR fixes:
Fixes # (Add the issue number or link)

Special notes for your reviewer:
This PR enhances stability and performance for Nginx deployments in Kubernetes.
Please verify the updated image version and probe configurations.

ALSO, I am an individual contributor.
Thanks & Regards
Rudra

@k8s-ci-robotk8s-ci-robot added the kind/featureCategorizes issue or PR as related to a new feature. labelFeb 22, 2025
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow ourrelease note process to remove it.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@k8s-ci-robotk8s-ci-robot added the do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels. labelFeb 22, 2025
@linux-foundation-easyclaLinux Foundation: EasyCLA
Copy link

linux-foundation-easyclabot commentedFeb 22, 2025•
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Rudra990 / name: Rudra (2e792cd)

@k8s-ci-robotk8s-ci-robot added the cncf-cla: noIndicates the PR's author has not signed the CNCF CLA. labelFeb 22, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome@Rudra990!

It looks like this is your first PR tokubernetes-client/python 🎉. Please refer to ourpull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment.Here is the bot commands documentation.

You can also check if kubernetes-client/python hasits own contribution guidelines.

You may want to refer to ourtesting guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow therecommended escalation practices. Also, for tips and tricks in the contribution process you may want to read theKubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robotk8s-ci-robot added size/MDenotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. and removed cncf-cla: noIndicates the PR's author has not signed the CNCF CLA. labelsFeb 22, 2025
@roycaihw
Copy link
Member

/assign@yliaog

@yliaog
Copy link
Contributor

/retest

@yliaog
Copy link
Contributor

close the pr and reopen to trigger running tests

/close

@k8s-ci-robot
Copy link
Contributor

@yliaog: Closed this PR.

In response tothis:

close the pr and reopen to trigger running tests

/close

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@yliaog
Copy link
Contributor

/reopen

@k8s-ci-robot
Copy link
Contributor

@yliaog: Reopened this PR.

In response tothis:

/reopen

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:Rudra990
Once this PR has been reviewed and has the lgtm label, please ask for approval fromyliaog. For more information seethe Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity,lifecycle/stale is applied
  • After 30d of inactivity sincelifecycle/stale was applied,lifecycle/rotten is applied
  • After 30d of inactivity sincelifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with/remove-lifecycle stale
  • Close this PR with/close
  • Offer to help out withIssue Triage

Please send feedback to sig-contributor-experience atkubernetes/community.

/lifecycle stale

@k8s-ci-robotk8s-ci-robot added the lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelJun 3, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity,lifecycle/stale is applied
  • After 30d of inactivity sincelifecycle/stale was applied,lifecycle/rotten is applied
  • After 30d of inactivity sincelifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with/remove-lifecycle rotten
  • Close this PR with/close
  • Offer to help out withIssue Triage

Please send feedback to sig-contributor-experience atkubernetes/community.

/lifecycle rotten

@k8s-ci-robotk8s-ci-robot added lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelsJul 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@roycaihwroycaihwAwaiting requested review from roycaihw

@yliaogyliaogAwaiting requested review from yliaog

Assignees

@yliaogyliaog

Labels
cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels.kind/featureCategorizes issue or PR as related to a new feature.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.size/MDenotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@Rudra990@k8s-ci-robot@roycaihw@yliaog@k8s-triage-robot
[8]ページ先頭
©2009-2025 Movatter.jp