Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Pass through empty newlines in watch stream#2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
marcelldls wants to merge1 commit intokubernetes-client:master
base:master
Choose a base branch
Loading
frommarcelldls:log-stream-newlines

Conversation

marcelldls
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

Pass through empty newlines in watch stream

Which issue(s) this PR fixes:

Fixes#2358

Special notes for your reviewer:

I'm not sure if this guard was needed for watch events

Does this PR introduce a user-facing change?

Pass through empty newlines in watch stream

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robotk8s-ci-robot added release-noteDenotes a PR that will be considered when it comes time to generate release notes. kind/bugCategorizes issue or PR as related to a bug. labelsFeb 19, 2025
@linux-foundation-easyclaLinux Foundation: EasyCLA
Copy link

linux-foundation-easyclabot commentedFeb 19, 2025•
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robotk8s-ci-robot added the cncf-cla: noIndicates the PR's author has not signed the CNCF CLA. labelFeb 19, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome@marcelldls!

It looks like this is your first PR tokubernetes-client/python 🎉. Please refer to ourpull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment.Here is the bot commands documentation.

You can also check if kubernetes-client/python hasits own contribution guidelines.

You may want to refer to ourtesting guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow therecommended escalation practices. Also, for tips and tricks in the contribution process you may want to read theKubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:marcelldls
Once this PR has been reviewed and has the lgtm label, please assignyliaog for approval. For more information seethe Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added the size/XSDenotes a PR that changes 0-9 lines, ignoring generated files. labelFeb 19, 2025
@roycaihw
Copy link
Member

Please sign the CLA

marcelldls reacted with thumbs up emoji

@k8s-ci-robotk8s-ci-robot added cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. and removed cncf-cla: noIndicates the PR's author has not signed the CNCF CLA. labelsFeb 27, 2025
@k8s-ci-robotk8s-ci-robot added the needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD. labelMar 22, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity,lifecycle/stale is applied
  • After 30d of inactivity sincelifecycle/stale was applied,lifecycle/rotten is applied
  • After 30d of inactivity sincelifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with/remove-lifecycle stale
  • Close this PR with/close
  • Offer to help out withIssue Triage

Please send feedback to sig-contributor-experience atkubernetes/community.

/lifecycle stale

@k8s-ci-robotk8s-ci-robot added the lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelJun 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabianvffabianvfAwaiting requested review from fabianvf

@roycaihwroycaihwAwaiting requested review from roycaihw

Assignees
No one assigned
Labels
cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.kind/bugCategorizes issue or PR as related to a bug.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD.release-noteDenotes a PR that will be considered when it comes time to generate release notes.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty newlines skipped when watching pod logs
4 participants
@marcelldls@k8s-ci-robot@roycaihw@k8s-triage-robot
[8]ページ先頭
©2009-2025 Movatter.jp