Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add support Lease-based leader election (rather than ConfigMaps) #1877#2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rvlane wants to merge1 commit intokubernetes-client:master
base:master
Choose a base branch
Loading
fromnokia:elector-lease

Conversation

rvlane
Copy link

@rvlanervlane commentedDec 17, 2024•
edited by roycaihw
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Enhance leaderelection module to support V1Lease based lease lock.

Which issue(s) this PR fixes:

Fixes#1877

Special notes for your reviewer:

Have coded this such that the LeaderElectionRecord is unchanged to ensure backward compatibility with anyone using the existing structures.

Does this PR introduce a user-facing change?

Support Lease-based leader election

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

guettli reacted with thumbs up emoji
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:rvlane
Once this PR has been reviewed and has the lgtm label, please assignyliaog for approval. For more information seethe Kubernetes Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added the do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels. labelDec 17, 2024
@linux-foundation-easyclaLinux Foundation: EasyCLA
Copy link

linux-foundation-easyclabot commentedDec 17, 2024•
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rvlane / name: Rick Lane (bb0c3f4)

@k8s-ci-robotk8s-ci-robot added cncf-cla: noIndicates the PR's author has not signed the CNCF CLA. needs-kindIndicates a PR lacks a `kind/foo` label and requires one. labelsDec 17, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome@rvlane!

It looks like this is your first PR tokubernetes-client/python 🎉. Please refer to ourpull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment.Here is the bot commands documentation.

You can also check if kubernetes-client/python hasits own contribution guidelines.

You may want to refer to ourtesting guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow therecommended escalation practices. Also, for tips and tricks in the contribution process you may want to read theKubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robotk8s-ci-robot added size/LDenotes a PR that changes 100-499 lines, ignoring generated files. release-note-noneDenotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels. labelsDec 17, 2024
@rvlane
Copy link
Author

@Invictus17 - can you please review this also? Thankis

@Invictus17
Copy link
Contributor

I'm not able to assign myself as reviewer@rvlane.

@rvlanervlane marked this pull request as draftDecember 19, 2024 13:42
@k8s-ci-robotk8s-ci-robot added the do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. labelDec 19, 2024
@rvlanervlane marked this pull request as ready for reviewDecember 19, 2024 13:53
@k8s-ci-robotk8s-ci-robot removed the do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. labelDec 19, 2024
@JacobHenner
Copy link

@rvlane do you intend to complete the CLA/can you confirm your contribution is licensed under the Apache License 2.0? I'm interested in adapting it for inclusion inkubernetes_asyncio, but I need to first ensure that its inclusion is legitimate.

Thanks!

tomplus reacted with thumbs up emoji

@k8s-ci-robotk8s-ci-robot added cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. and removed cncf-cla: noIndicates the PR's author has not signed the CNCF CLA. labelsJan 7, 2025
@rvlane
Copy link
Author

@JacobHenner I have been added to my company CLA and have approved the CLA just now.

JacobHenner and tomplus reacted with thumbs up emoji

@roycaihw
Copy link
Member

/assign@Invictus17@roycaihw
/cc@Invictus17

@k8s-ci-robot
Copy link
Contributor

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: Invictus17.

Note that onlykubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response tothis:

/assign@Invictus17@roycaihw
/cc@Invictus17

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity,lifecycle/stale is applied
  • After 30d of inactivity sincelifecycle/stale was applied,lifecycle/rotten is applied
  • After 30d of inactivity sincelifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with/remove-lifecycle stale
  • Close this PR with/close
  • Offer to help out withIssue Triage

Please send feedback to sig-contributor-experience atkubernetes/community.

/lifecycle stale

@k8s-ci-robotk8s-ci-robot added the lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelApr 15, 2025
@JacobHenner
Copy link

/remove-lifecycle stale

@k8s-ci-robotk8s-ci-robot removed the lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelApr 16, 2025
@MadJlzz
Copy link

@fabianvf@roycaihw do you need help for the testing/review of this MR? I am interested for this feature as well!

@roycaihwroycaihw added the kind/featureCategorizes issue or PR as related to a new feature. labelJun 24, 2025
@k8s-ci-robotk8s-ci-robot added release-noteDenotes a PR that will be considered when it comes time to generate release notes. and removed needs-kindIndicates a PR lacks a `kind/foo` label and requires one. release-note-noneDenotes a PR that doesn't merit a release note. labelsJun 24, 2025
Copy link
Member

@roycaihwroycaihw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM overall. Could you add a test?

@@ -14,7 +14,7 @@


class LeaderElectionRecord:
#Annotation usedin the lock object
#Lease configuration fromin the lock object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

s/from in the/from the

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

will do, thanks

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@roycaihwroycaihwroycaihw left review comments

@fabianvffabianvfAwaiting requested review from fabianvf

Labels
cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.kind/featureCategorizes issue or PR as related to a new feature.release-noteDenotes a PR that will be considered when it comes time to generate release notes.size/LDenotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support Lease-based leader election (rather than ConfigMaps)
7 participants
@rvlane@k8s-ci-robot@Invictus17@JacobHenner@roycaihw@k8s-triage-robot@MadJlzz
[8]ページ先頭
©2009-2025 Movatter.jp