Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

google-auth Made as optional dependency#2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
shivanand007 wants to merge3 commits intokubernetes-client:master
base:master
Choose a base branch
Loading
fromshivanand007:add-optional-google-auth

Conversation

shivanand007
Copy link

@shivanand007shivanand007 commentedOct 8, 2024•
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Makes Google auth as optional dependency, gives users a option to install it separately.

Which issue(s) this PR fixes:

Fixes#2249

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This change modifies the `setup.py` file to move `google-auth` to the `extras_require` section,allowing it to be installed with `pip install kubernetes[google-auth]`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

darren-recentive reacted with thumbs up emoji
@k8s-ci-robotk8s-ci-robot added release-note-noneDenotes a PR that doesn't merit a release note. kind/featureCategorizes issue or PR as related to a new feature. labelsOct 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:shivanand007
Once this PR has been reviewed and has the lgtm label, please assignroycaihw for approval. For more information seethe Kubernetes Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. size/XSDenotes a PR that changes 0-9 lines, ignoring generated files. labelsOct 8, 2024
Copy link
Member

@roycaihwroycaihw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a release note with instructions of how to install google-auth going forward.

We should also make sure the tests pass. I wonder if we need to update the test pipeline to install google-auth as well.

/retest

@k8s-ci-robotk8s-ci-robot added release-noteDenotes a PR that will be considered when it comes time to generate release notes. and removed release-note-noneDenotes a PR that doesn't merit a release note. labelsOct 9, 2024
@shivanand007
Copy link
Author

shivanand007 commentedOct 9, 2024•
edited
Loading

Please add a release note with instructions of how to install google-auth going forward.

--> I have added the required release note, kindly have a review for the same.

We should also make sure the tests pass. I wonder if we need to update the test pipeline to install google-auth as well.

--> Yes, As we have Removed google-auth from requirements.txt, This must be a dependency in code which makes test cases to fail, I will check the code and see if we can make those code blocks optional as well, Additionally we have to update the test pipeline to test this use case.

/retest

@k8s-ci-robotk8s-ci-robot added size/MDenotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XSDenotes a PR that changes 0-9 lines, ignoring generated files. labelsOct 9, 2024
@shivanand007
Copy link
Author

@roycaihw
I have made the necessary changes in code to make google-auth as optional, Requesting to Change Test Pipeline, So That we can pass all the E2E test Cases.

@shivanand007
Copy link
Author

/retest

@k8s-ci-robot
Copy link
Contributor

@shivanand007: Cannot trigger testing until a trusted user reviews the PR and leaves an/ok-to-test message.

In response tothis:

/retest

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity,lifecycle/stale is applied
  • After 30d of inactivity sincelifecycle/stale was applied,lifecycle/rotten is applied
  • After 30d of inactivity sincelifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with/remove-lifecycle stale
  • Close this PR with/close
  • Offer to help out withIssue Triage

Please send feedback to sig-contributor-experience atkubernetes/community.

/lifecycle stale

@k8s-ci-robotk8s-ci-robot added the lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelJan 10, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity,lifecycle/stale is applied
  • After 30d of inactivity sincelifecycle/stale was applied,lifecycle/rotten is applied
  • After 30d of inactivity sincelifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with/remove-lifecycle rotten
  • Close this PR with/close
  • Offer to help out withIssue Triage

Please send feedback to sig-contributor-experience atkubernetes/community.

/lifecycle rotten

@k8s-ci-robotk8s-ci-robot added lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelsFeb 9, 2025
@mindw
Copy link

/remove-lifecycle rotten

@k8s-ci-robotk8s-ci-robot removed the lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed. labelFeb 10, 2025
@darren-recentive
Copy link

@roycaihw@yliaog Can we help review@shivanand007 's changes and retest please

@roycaihw
Copy link
Member

Sorry for the late reply.

/ok-to-test

@k8s-ci-robotk8s-ci-robot added the ok-to-testIndicates a non-member PR verified by an org member that is safe to test. labelMay 13, 2025
@roycaihw
Copy link
Member

/retest

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@roycaihwroycaihwroycaihw left review comments

@yliaogyliaogAwaiting requested review from yliaog

Assignees
No one assigned
Labels
cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.kind/featureCategorizes issue or PR as related to a new feature.ok-to-testIndicates a non-member PR verified by an org member that is safe to test.release-noteDenotes a PR that will be considered when it comes time to generate release notes.size/MDenotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make google-auth an optional dependency
6 participants
@shivanand007@k8s-ci-robot@k8s-triage-robot@mindw@darren-recentive@roycaihw
[8]ページ先頭
©2009-2025 Movatter.jp