Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

oidc provider behind proxy#2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
SkiAn2007 wants to merge1 commit intokubernetes-client:master
base:master
Choose a base branch
Loading
fromSkiAn2007:patch-1

Conversation

SkiAn2007
Copy link

@SkiAn2007SkiAn2007 commentedJul 25, 2024•
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This fix allows client to communicate with OIDC provider which located out of company perimeter and requires to use proxy server

Does this PR introduce a user-facing change?

NONE

This fix allows client to communicate with OIDC provider which located out or company perimeter and requires to use proxy server
@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow ourrelease note process to remove it.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@k8s-ci-robotk8s-ci-robot added do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. kind/bugCategorizes issue or PR as related to a bug. do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels. labelsJul 25, 2024
@linux-foundation-easyclaLinux Foundation: EasyCLA
Copy link

linux-foundation-easyclabot commentedJul 25, 2024•
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robotk8s-ci-robot added the cncf-cla: noIndicates the PR's author has not signed the CNCF CLA. labelJul 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome@SkiAn2007!

It looks like this is your first PR tokubernetes-client/python 🎉. Please refer to ourpull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment.Here is the bot commands documentation.

You can also check if kubernetes-client/python hasits own contribution guidelines.

You may want to refer to ourtesting guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow therecommended escalation practices. Also, for tips and tricks in the contribution process you may want to read theKubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robotk8s-ci-robot added the size/XSDenotes a PR that changes 0-9 lines, ignoring generated files. labelJul 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:SkiAn2007
Once this PR has been reviewed and has the lgtm label, please assignroycaihw for approval. For more information seethe Kubernetes Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. and removed cncf-cla: noIndicates the PR's author has not signed the CNCF CLA. labelsJul 25, 2024
@SkiAn2007
Copy link
Author

Facing with issues to run tests locally, is there any tests pipeline on PR?

@SkiAn2007SkiAn2007 marked this pull request as ready for reviewJuly 25, 2024 10:35
@k8s-ci-robotk8s-ci-robot removed the do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. labelJul 25, 2024
@roycaihw
Copy link
Member

#2256 (comment) Yes the PR has presubmits. Looks like it was waiting for approval to run. I just triggered the test.

@@ -420,7 +420,7 @@ def _load_oid_token(self, provider):
return self.token

def _refresh_oidc(self, provider):
config = Configuration()
config = Configuration().get_default_copy()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we unit test this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Who do you mean? As far as I see all tests are passed.
I checked this change locally, and it works.

@roycaihw
Copy link
Member

/assign

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity,lifecycle/stale is applied
  • After 30d of inactivity sincelifecycle/stale was applied,lifecycle/rotten is applied
  • After 30d of inactivity sincelifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with/remove-lifecycle stale
  • Close this PR with/close
  • Offer to help out withIssue Triage

Please send feedback to sig-contributor-experience atkubernetes/community.

/lifecycle stale

@k8s-ci-robotk8s-ci-robot added the lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelNov 12, 2024
@SkiAn2007
Copy link
Author

@roycaihw@yliaog@fabianvf

What's the next step in the review? What is required on my part?

/remove-lifecycle stale

@k8s-ci-robotk8s-ci-robot removed the lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelNov 13, 2024
@yliaog
Copy link
Contributor

i think@roycaihw was asking if you could add a new unittest case for this

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity,lifecycle/stale is applied
  • After 30d of inactivity sincelifecycle/stale was applied,lifecycle/rotten is applied
  • After 30d of inactivity sincelifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with/remove-lifecycle stale
  • Close this PR with/close
  • Offer to help out withIssue Triage

Please send feedback to sig-contributor-experience atkubernetes/community.

/lifecycle stale

@k8s-ci-robotk8s-ci-robot added the lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelFeb 11, 2025
@SkiAn2007
Copy link
Author

@yliaog@roycaihw For testing such functionality requires prepared test environment
At least I can not imagine how to test it without real infrastructure.
If you have any suggestions what would be good enough I can try..

/remove-lifecycle stale

@k8s-ci-robotk8s-ci-robot removed the lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelFeb 11, 2025
@yliaog
Copy link
Contributor

ok, i'm ok with merging the PR if you tested it locally, and it worked fine.

SkiAn2007 reacted with thumbs up emoji

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity,lifecycle/stale is applied
  • After 30d of inactivity sincelifecycle/stale was applied,lifecycle/rotten is applied
  • After 30d of inactivity sincelifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with/remove-lifecycle stale
  • Close this PR with/close
  • Offer to help out withIssue Triage

Please send feedback to sig-contributor-experience atkubernetes/community.

/lifecycle stale

@k8s-ci-robotk8s-ci-robot added the lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelMay 13, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity,lifecycle/stale is applied
  • After 30d of inactivity sincelifecycle/stale was applied,lifecycle/rotten is applied
  • After 30d of inactivity sincelifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with/remove-lifecycle rotten
  • Close this PR with/close
  • Offer to help out withIssue Triage

Please send feedback to sig-contributor-experience atkubernetes/community.

/lifecycle rotten

@k8s-ci-robotk8s-ci-robot added lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale. labelsJun 12, 2025
@SkiAn2007
Copy link
Author

@yliaog lets merge it? almost one year has almost passed since publication

/remove-lifecycle rotten

@k8s-ci-robotk8s-ci-robot removed the lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed. labelJun 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabianvffabianvfAwaiting requested review from fabianvf

@yliaogyliaogAwaiting requested review from yliaog

@roycaihwroycaihwAwaiting requested review from roycaihw

Assignees

@roycaihwroycaihw

Labels
cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels.kind/bugCategorizes issue or PR as related to a bug.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@SkiAn2007@k8s-ci-robot@roycaihw@k8s-triage-robot@yliaog
[8]ページ先頭
©2009-2025 Movatter.jp