Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Rebase and fixes for https://github.com/kubernetes-client/python/pull/2147#2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

PhroZenOne
Copy link

I just took the branch from#2147 and rebased it, I also fixed the client patch but I am unsure about its usage.

I also ran the scripts/update-client.sh to update the source files that are autogenerated.

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow ourrelease note process to remove it.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@k8s-ci-robotk8s-ci-robot added the do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels. labelJul 22, 2024
@linux-foundation-easyclaLinux Foundation: EasyCLA
Copy link

linux-foundation-easyclabot commentedJul 22, 2024•
edited
Loading

CLA Not Signed

@k8s-ci-robotk8s-ci-robot added cncf-cla: noIndicates the PR's author has not signed the CNCF CLA. needs-kindIndicates a PR lacks a `kind/foo` label and requires one. labelsJul 22, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome@PhroZenOne!

It looks like this is your first PR tokubernetes-client/python 🎉. Please refer to ourpull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment.Here is the bot commands documentation.

You can also check if kubernetes-client/python hasits own contribution guidelines.

You may want to refer to ourtesting guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow therecommended escalation practices. Also, for tips and tricks in the contribution process you may want to read theKubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robotk8s-ci-robot added the size/XXLDenotes a PR that changes 1000+ lines, ignoring generated files. labelJul 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:PhroZenOne
Once this PR has been reviewed and has the lgtm label, please assignyliaog for approval. For more information seethe Kubernetes Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

This is needed for the proxy client to generate socks support
I'm unsure about the function of this patch but I tried to keep the logicthe same as the previous behavior. Just adjusting it so it applies tothe new source
Previously it used kubernetes.client.apis and it was deprecated in favor of api
This commit contains the changes applied by running scripts/update-client.shNo manual changes, only auto generated code
@PhroZenOne
Copy link
Author

PhroZenOne commentedJul 22, 2024•
edited
Loading

Closing as this needs a lot more work as the API has changed. See comment on#2147

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabianvffabianvfAwaiting requested review from fabianvf

@roycaihwroycaihwAwaiting requested review from roycaihw

Assignees
No one assigned
Labels
cncf-cla: noIndicates the PR's author has not signed the CNCF CLA.do-not-merge/release-note-label-neededIndicates that a PR should not merge because it's missing one of the release note labels.needs-kindIndicates a PR lacks a `kind/foo` label and requires one.size/XXLDenotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@PhroZenOne@k8s-ci-robot@rolf-moz
[8]ページ先頭
©2009-2025 Movatter.jp