Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Generic client-go store#133036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
skitt wants to merge6 commits intokubernetes:master
base:master
Choose a base branch
Loading
fromskitt:client-go-typed-store-example

Conversation

skitt
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This adds typed variants of the client-go store and related data structures. This allows the compiler to enforce types at build-time.

The PersistentVolume controller is modified to use the typed store to illustrate the benefits.

Many client-go stores are based on informers, so this can’t be pushed too far without having to generify informers too.

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with/test all

@k8s-ci-robotk8s-ci-robot added do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. release-note-noneDenotes a PR that doesn't merit a release note. size/XLDenotes a PR that changes 500-999 lines, ignoring generated files. kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. labelsJul 17, 2025
@skitt
Copy link
MemberAuthor

/test all

@k8s-ci-robotk8s-ci-robot added the do-not-merge/needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one. labelJul 17, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying thetriage/accepted label and provide further guidance.

Thetriage/accepted label can be added by org members by writing/triage accepted in a comment.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@k8s-ci-robotk8s-ci-robot added needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one. needs-priorityIndicates a PR lacks a `priority/foo` label and requires one. sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery. sig/appsCategorizes an issue or PR as relevant to SIG Apps. sig/storageCategorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one. labelsJul 17, 2025
@github-project-automationgithub-project-automationbot moved this toNeeds Triage inSIG AppsJul 17, 2025
@skitt
Copy link
MemberAuthor

/test pull-kubernetes-linter-hints

@skitt
Copy link
MemberAuthor

/test pull-kubernetes-verify

@aojea
Copy link
Member

/test pull-kubernetes-apidiff-client-go

The contents of this file are only used in tests, but because itdoesn't end in test its variables leak into regular builds. This pullsin cmpopts.IgnoreFields which prevents dead code elimination whengenerifying client-go.Signed-off-by: Stephen Kitt <skitt@redhat.com>
@k8s-ci-robotk8s-ci-robot added the sig/schedulingCategorizes an issue or PR as relevant to SIG Scheduling. labelJul 18, 2025
@skitt
Copy link
MemberAuthor

/test pull-kubernetes-verify
/test pull-kubernetes-apidiff-client-go

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:skitt
Once this PR has been reviewed and has the lgtm label, please assignthockin for approval. For more information seethe Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

This should have been moved to the test file with GetByKey(), but itcan be entirely replaced by slices.Clone() so use that instead.Signed-off-by: Stephen Kitt <skitt@redhat.com>
@skitt
Copy link
MemberAuthor

/test pull-kubernetes-apidiff-client-go

@k8s-ci-robot
Copy link
Contributor

@skitt: The following testfailed, say/retest to rerun all failed tests or/retest-required to rerun all mandatory failed tests:

Test nameCommitDetailsRequiredRerun command
pull-kubernetes-apidiff-client-go401e6d1linkfalse/test pull-kubernetes-apidiff-client-go

Full PR test history.Your PR dashboard. Please help us cut down on flakes bylinking to anopen issue when you hit one in your PR.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository. I understand the commands that are listedhere.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mauriciopoppemauriciopoppeAwaiting requested review from mauriciopoppe

@wojtek-twojtek-tAwaiting requested review from wojtek-t

Assignees
No one assigned
Labels
cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.needs-priorityIndicates a PR lacks a `priority/foo` label and requires one.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.release-note-noneDenotes a PR that doesn't merit a release note.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.sig/appsCategorizes an issue or PR as relevant to SIG Apps.sig/schedulingCategorizes an issue or PR as relevant to SIG Scheduling.sig/storageCategorizes an issue or PR as relevant to SIG Storage.size/XLDenotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@skitt@k8s-ci-robot@aojea
[8]ページ先頭
©2009-2025 Movatter.jp