Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

WebSocket HTTPS Proxy support#129872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@seans3
Copy link
Contributor

@seans3seans3 commentedJan 29, 2025•
edited
Loading

  • Incorporates latestgorilla/websocket library, which includes missing HTTPS Proxy support.
  • Tests both the WebSocket "http" proxy support and "https" proxy support.
  • Stress tested new WebSocket proxy unit test
$ stress ./remotecommand.test -test.run TestWebSocketClient_ProxySucceeds5s: 2297 runs so far, 0 failures10s: 4587 runs so far, 0 failures15s: 6571 runs so far, 0 failures20s: 7878 runs so far, 0 failures25s: 9142 runs so far, 0 failures30s: 10452 runs so far, 0 failures35s: 12035 runs so far, 0 failures40s: 13357 runs so far, 0 failures45s: 14719 runs so far, 0 failures50s: 16143 runs so far, 0 failures55s: 17490 runs so far, 0 failures1m0s: 18666 runs so far, 0 failures1m5s: 19978 runs so far, 0 failures

/kind bug

- Includes WebSockets HTTPS proxy support

@k8s-ci-robotk8s-ci-robot added release-note-noneDenotes a PR that doesn't merit a release note. do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress. kind/bugCategorizes issue or PR as related to a bug. size/LDenotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one. needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one. needs-priorityIndicates a PR lacks a `priority/foo` label and requires one. sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one. labelsJan 29, 2025
@k8s-ci-robotk8s-ci-robot added the approvedIndicates a PR has been approved by an approver from all required OWNERS files. labelJan 29, 2025
@seans3seans3force-pushed thewebsocket-https-proxy branch 3 times, most recently from209ca51 to8d7f1aeCompareJanuary 29, 2025 23:34
@k8s-ci-robotk8s-ci-robot removed the approvedIndicates a PR has been approved by an approver from all required OWNERS files. labelFeb 12, 2025
@k8s-ci-robotk8s-ci-robot added area/apiserver area/cloudprovider area/dependencyIssues or PRs related to dependency changes area/kubectl area/kubelet sig/architectureCategorizes an issue or PR as relevant to SIG Architecture. sig/authCategorizes an issue or PR as relevant to SIG Auth. sig/cliCategorizes an issue or PR as relevant to SIG CLI. sig/cloud-providerCategorizes an issue or PR as relevant to SIG Cloud Provider. labelsFeb 20, 2025
@seans3
Copy link
ContributorAuthor

/triage accepted

@k8s-ci-robotk8s-ci-robot added triage/acceptedIndicates an issue or PR is ready to be actively worked on. and removed needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one. labelsMar 19, 2025
@seans3seans3force-pushed thewebsocket-https-proxy branch fromb8e62ec tof73945aCompareMarch 19, 2025 18:51
@aojea
Copy link
Member

/approve
/assign@liggitt

@liggitt
Copy link
Member

/lgtm
/approve

When we get a 1.5.4 tag from gorilla, go ahead and update to that as a follow-up

@k8s-ci-robotk8s-ci-robot added the lgtm"Looks good to me", indicates that a PR is ready to be merged. labelMar 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 819f7b2c55b42a3913d470eb6f715eaf37d247ec

@k8s-ci-robotk8s-ci-robot added the approvedIndicates a PR has been approved by an approver from all required OWNERS files. labelMar 20, 2025
@liggitt
Copy link
Member

/approve cancel
/hold for a check of an upstream unit test

@k8s-ci-robotk8s-ci-robot added do-not-merge/holdIndicates that a PR should not merge because someone has issued a /hold command. and removed approvedIndicates a PR has been approved by an approver from all required OWNERS files. labelsMar 20, 2025
@liggitt
Copy link
Member

/retest

/hold cancel
resolved upstream unit test issue ingorilla/websocket#982, test-only issue that won't impact this repo

@k8s-ci-robotk8s-ci-robot removed the do-not-merge/holdIndicates that a PR should not merge because someone has issued a /hold command. labelMar 20, 2025
@liggittliggitt added this to thev1.33 milestoneMar 20, 2025
@aojea
Copy link
Member

@liggitt you need to approve again

@liggitt
Copy link
Member

/approve

seans3 reacted with thumbs up emojiseans3 reacted with rocket emoji

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isAPPROVED

This pull-request has been approved by:aojea,liggitt,seans3

The full list of commands accepted by this bot can be foundhere.

The pull request process is describedhere

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added the approvedIndicates a PR has been approved by an approver from all required OWNERS files. labelMar 20, 2025
@k8s-ci-robotk8s-ci-robot merged commit6f13ba0 intokubernetes:masterMar 20, 2025
16 checks passed
@github-project-automationgithub-project-automationbot moved this from!SIG Auth toClosed / Done inSIG AuthMar 20, 2025
@github-project-automationgithub-project-automationbot moved this fromNeeds Triage toDone inSIG CLIMar 20, 2025
@lizthegrey
Copy link

Some of the potential issues here might be solveable by rolling back the minimum version of websocket in client-go only, which means that the rest of the code will work fine under test, but that clients won't pick up the mandatory upgrade to a non-semver websocket unless they also depend upon the core k8s code.

@liggitt
Copy link
Member

liggitt commentedMay 9, 2025•
edited
Loading

Some of the potential issues here might be solveable by rolling back the minimum version of websocket in client-go only, which means that the rest of the code will work fine under test, but that clients won't pick up the mandatory upgrade to a non-semver websocket unless they also depend upon the core k8s code.

go work sync brings all modules in the workspace up to the MVS level used by any module, so back-leveling justclient-go doesn't work (this is actually more coherent, not something I consider unfortunate, but does mean that one workaround isn't an option here).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@liggittliggittliggitt left review comments

@aojeaaojeaAwaiting requested review from aojea

Assignees

@liggittliggitt

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.area/apiserverarea/cloudproviderarea/dependencyIssues or PRs related to dependency changesarea/kubectlarea/kubeletcncf-cla: yesIndicates the PR's author has signed the CNCF CLA.kind/bugCategorizes issue or PR as related to a bug.lgtm"Looks good to me", indicates that a PR is ready to be merged.needs-priorityIndicates a PR lacks a `priority/foo` label and requires one.release-noteDenotes a PR that will be considered when it comes time to generate release notes.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.sig/architectureCategorizes an issue or PR as relevant to SIG Architecture.sig/authCategorizes an issue or PR as relevant to SIG Auth.sig/cliCategorizes an issue or PR as relevant to SIG CLI.sig/cloud-providerCategorizes an issue or PR as relevant to SIG Cloud Provider.sig/instrumentationCategorizes an issue or PR as relevant to SIG Instrumentation.sig/networkCategorizes an issue or PR as relevant to SIG Network.sig/nodeCategorizes an issue or PR as relevant to SIG Node.size/LDenotes a PR that changes 100-499 lines, ignoring generated files.triage/acceptedIndicates an issue or PR is ready to be actively worked on.wg/device-managementCategorizes an issue or PR as relevant to WG Device Management.

Projects

Archived in project
Archived in project
Archived in project
Archived in project

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

5 participants

@seans3@aojea@liggitt@k8s-ci-robot@lizthegrey
[8]ページ先頭
©2009-2025 Movatter.jp