Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork198
Adds a setting (default false) to use custom tray icon image#895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hi there, sorry for waiting so long for this PR, I was on vacation and recently get almost no time for developing ksnip. I like the idea of having this kind of customization :) I just had a brief look though the PR, more will hopefully come in next couple of days. Regarding the radio buttons, we usually have them vertically aligned, you have it now horizontally, any specific reason or could you place them vertically to be more inline with the remaining ones? Unit tests are run by the CI automatically. |
Logansfury commentedNov 30, 2024
Is this a series of edits to be made to existing ksnip files to add this system tray functionality to a ksnip that previously did not have this feature? |
Uh oh!
There was an error while loading.Please reload this page.
This adds in a setting to use a custom tray icon. It works with svgs, and I've got it set on my system now to use the same icon for ksnip from my icon pack.
New Settings
(note: ksnip doesn't seem to be able to take screenshots of it's own settings window so I had to use Spectacle, not sure if that's intentional or not)
Example custom icon
This is the first time I touched C++ since college, so if I did anything wrong let me know!
TODO: