Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adds a setting (default false) to use custom tray icon image#895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
NathanC wants to merge1 commit intoksnip:master
base:master
Choose a base branch
Loading
fromNathanC:custom-tray-icon

Conversation

NathanC
Copy link

@NathanCNathanC commentedAug 1, 2022
edited
Loading

This adds in a setting to use a custom tray icon. It works with svgs, and I've got it set on my system now to use the same icon for ksnip from my icon pack.

New Settings

image

(note: ksnip doesn't seem to be able to take screenshots of it's own settings window so I had to use Spectacle, not sure if that's intentional or not)

Example custom icon

image

This is the first time I touched C++ since college, so if I did anything wrong let me know!

TODO:

  • Display error message to user on falling back to default icon, or at least log it somehow
  • Run tests (if they're not done automatically by GitHub)

coffebar reacted with rocket emoji
@DamirPorobic
Copy link
Member

Hi there, sorry for waiting so long for this PR, I was on vacation and recently get almost no time for developing ksnip. I like the idea of having this kind of customization :)

I just had a brief look though the PR, more will hopefully come in next couple of days. Regarding the radio buttons, we usually have them vertically aligned, you have it now horizontally, any specific reason or could you place them vertically to be more inline with the remaining ones?

Unit tests are run by the CI automatically.

@Logansfury
Copy link

Is this a series of edits to be made to existing ksnip files to add this system tray functionality to a ksnip that previously did not have this feature?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@NathanC@DamirPorobic@Logansfury

[8]ページ先頭

©2009-2025 Movatter.jp