Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork198
Further attempt to fix qt5 build#1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I'm not attempting to fix qt6 build here
Now this is ready to merge, as you can see by the green tick :) |
| @@ -62,6 +62,7 @@ jobs: | |||
| package-exe: | |||
| if: ${{ github.event_name == 'push' }} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
For what do we need those guards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In the PR there's no access to secrets, therefore upload fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Though it may be a good idea to move the guards closer to upload itself. Then it'll be possible to download the build artifact from the PR even without creating the release
| if [[ "$QT_VERSION" == 6* ]]; then | ||
| echo "USE_QT6=yes" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we have used the convention true/false or on/off.
| host: 'linux' | ||
| install-deps: 'true' | ||
| - name: Install dependencies | ||
| run: sudo apt-get install extra-cmake-modules libxcb-xfixes0-dev xvfb | ||
| - name: Install Qt6 dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This one is going to be installed for Gt5 and Qt6, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was going to add an "if" here, but then decided that it doesn't hurt qt5 either, and eventually qt5 build would be removed anyway...
So went with just a comment instead
1ab2004 intoksnip:masterUh oh!
There was an error while loading.Please reload this page.
Let's see how it works :) |
No description provided.