Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork198
New: Allow pixel based adjustments via arrow keys when capturing an area.#1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+32 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…rea.Closesksnip#646,closesksnip#816,closesksnip#887,closesksnip#1002
DamirPorobic approved these changesSep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looking good, thank you for providing this PR :)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This allows to adjust the cursor position with the arrow keys when capturing an area.
It usesQCursor to set the mouse cursor position when the arrow keys are pressed (setPos). With this it is not possible to move beyond screen boundaries (at least on X11 - see below).
I've added a notice to the
SnippingAreaSelectorInfoTextclass so users are aware of the feature. Let me know if I need to do something so thetranslation system works correctly.I've also added this new feature to the two changelog files - inspired by the previous commits.
Important
I've only tested this on my personal machine running Linux Mint 21.3 Cinnamon (X11) with Qt 5.15.2. I don't know how the Qt Mouse positioning function handles other window managers.
I am trying rn to build with Qt6 and then build the AppImage so I can test in a vm with different window managers.
All the existing tests pass - as expected.
Here is a small demo video:
arrow.adjustments.demo.mp4
There may be more issues related to this but these are the ones I could find with a quick search:
Closes#646,closes#816,closes#887,closes#1002