- Notifications
You must be signed in to change notification settings - Fork161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Tests: pkg dynamiccontroller: increases test coverage#414
base:main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@DhairyaMajmudar ! left a few comments inline
| expected: true, | ||
| }, | ||
| { | ||
| name: "one unsynced informer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can we have some test cases forone synced informer,many synced informers andmany sync informers and many unsynced informers ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@a-hilaly I've added the suggested changes and also simplified them a bit but the tests cases forone synced informer andmany synced informers are failing.
It seems to be like some bug with actual function, can you pls. confirm once.
Signed-off-by: Dhairya Majmudar <2022kuec2045@iiitkota.ac.in>
Description
pkg/dynamiccontroller/dynamiccontroller_test.gofileio/ioutilpackage toioScreenShots
cc:@a-hilaly