Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Only fail on error, add option to ignore warnings#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
krampstudio merged 2 commits intokrampstudio:0.6.xfromRaynes:errors
May 24, 2015

Conversation

Raynes
Copy link
Contributor

This pull request extends on the error checking a bit to ignore
warnings. Warnings do not necessitate a complete failure. For example,
with ES6, you're gonna get warnings about new stuff no matter what –
you can still generate docs!

Furthermore, added an ignoreWarnings option to not print warnings.

This pull request extends on the error checking a bit to ignorewarnings. Warnings do not necessitate a complete failure. For example,with ES6, you're gonna get warnings about new stuff no matter what –you can still generate docs!Furthermore, added an ignoreWarnings option to not print warnings.
@krampstudio
Copy link
Owner

Isn't the role of theforce flag to ignore warnings ?

@Raynes
Copy link
ContributorAuthor

Yes, but the way this is being done makes no sense. It's failing immediately on warnings. Warnings in jsdoc and warnings in grunt are two different things. Most importantly, even if you --force, you don't see all the warnings and errors. jsdoc doesn't even die during errors, it keeps going and shows you all of them. I mostly just want all of the output, warnings included.

@simonomis
Copy link

This feature would be really useful for me too. I'm writing ES6 modules and because I have to useforce I'm missing genuine jsdoc errors because the exit status is always 0. Being able to ignore warnings (because they are almost always about ES6 import/export nodes) but still fail on errors would be very helpful at least until all ES6 syntax is fully supported.

@krampstudiokrampstudio self-assigned thisMar 20, 2015
@krampstudio
Copy link
Owner

I'll merge it as soon as I have some time to do it.

krampstudio added a commit that referenced this pull requestMay 24, 2015
Only fail on error, add option to ignore warnings
@krampstudiokrampstudio merged commitc08d2f6 intokrampstudio:0.6.xMay 24, 2015
@krampstudio
Copy link
Owner

Merged but I need to handle theignoreWarning option and do some testing before publishing to npm.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@krampstudiokrampstudio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Raynes@krampstudio@simonomis

[8]ページ先頭

©2009-2025 Movatter.jp