- Notifications
You must be signed in to change notification settings - Fork1.9k
Allow specifying color= in shellcheckrc (closes #2350)#2352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
koalaman commentedOct 9, 2021
It's not entirely straight forward because For example, you can do and then The |
oliv3r commentedOct 14, 2021
Alternatively, making sure auto 'always' works is an option :p but in seriousness, I do like having options stored in a per-repo level. I think it should just traverse in the tree though, right? so global, trumps user, trumps root, trumps folder setting. So if you have it in your local rc, but not anywhere in the repo; you get it. I suppose one could argue on the directory vs root level; it could be that 'note, some settings, regardless where they are set, are applied to the repo as a whole, when asking shellcheck to auto-scan for files, if this is undesiresd invoke shellcheck on a 'per file' basis' and there, it should favor local settings over root settings? |
cf26262 toba5c415CompareSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>
Alhadis commentedDec 21, 2021
IMHO, this really belongs in an environment variable ( |
50074dc toeac8effCompare
To be able to set the color option in the config file (detection in GitLab CI fails for example) is useful when using template shellcheck containers for one. Secondly, storing config in the repo is also a thing :)
Sadly, I got a bit overconfident and got lost very quickly. I never seen haskell before so there's a learning curve required I suppose. I did make a start hopefully for whomever can pick it up :)