This repository was archived by the owner on Feb 4, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork87
fix: ending portal loop without processing its flags#119
Merged
khoih-prog merged 2 commits intokhoih-prog:masterfromslaesh:fix-stopping-loop-without-taking-action2Oct 25, 2022
Merged
fix: ending portal loop without processing its flags#119
khoih-prog merged 2 commits intokhoih-prog:masterfromslaesh:fix-stopping-loop-without-taking-action2Oct 25, 2022
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Owner
khoih-prog commentedOct 25, 2022
Owner
khoih-prog commentedOct 25, 2022
OK, I'm merging now. Thanks |
Owner
khoih-prog commentedOct 25, 2022
Hi@slaesh The newESPAsync_WiFiManager v1.15.1 has just been released. Your contribution is noted inContributions and Thanks Best Regards, Releases v1.15.1
|
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since the yield was AFTER processing the flags (connect/stop)..
AND we were modifying the loop-criteria, the loop could end BEFORE we had processed our flags!
SO, yield before and there is no need to modify the timeout at all :)