Moving to devcontainers as codesandbox is stopping supporting sandbox.config.json
Hardcoding seed data in the example, whilst keeping theseed-data command
Setting prisma to inherit versions
Removingpostinstall to avoid possible conflicts with prisma minor patch changes to their generator

To solve for the examples snapshot tests:

leaving the schema's in the example's folder
adding a newtest:monorepo-snapshot-test command to replacepostinstall
added a newtest:examples-snapshot-tests to root package.json which targets the above command recursively in all examples folders
added a newexamples_snapshot_tests test to ci to run the above command once

This is going to significantly reduce the time for actions as each of the smoke tests currently runs the postinstall for all the examples each time (~5m).

This approach also allows us to handleframework-nextjs-two-servers as well.

Copy link

codesandbox-cibot commentedAug 13, 2024•
edited
Loading

This pull request is automatically built and testable inCodeSandbox.

To see build info of the built libraries, clickhere or the icon next to each commit SHA.

Latest deployment of this branch, based on commitb23b849:

Sandbox	Source
@keystone-6/sandbox	Configuration

Copy link

Member

dcousens commentedAug 13, 2024•
edited
Loading

Seed data - I think it's best if we just stop ignoring the example.db files

Honestly, I think this is a good approach. We do this already, and it's solid.

The primary downside I can see is the lack of human readability for the binary file on GitHub. We otherwise have theexamples/script example to showcase data seeding.

Copy link

Member

dcousens commentedAug 13, 2024•
edited
Loading

Maybe we can build thekeystone.db files deterministically from our rootscripts/ folder?

dcousens reviewed

Aug 13, 2024

View reviewed changes

examples/usecase-todo/package.jsonShow resolvedHide resolved

dcousens reviewed

Aug 13, 2024

View reviewed changes

examples/usecase-todo/.codesandbox/tasks.json OutdatedShow resolvedHide resolved

dcousens reviewed

Aug 13, 2024

View reviewed changes

examples/usecase-todo/keystone.ts OutdatedShow resolvedHide resolved

dcousens reviewed

Aug 13, 2024

View reviewed changes

examples/usecase-todo/package.jsonShow resolvedHide resolved

Copy link

ContributorAuthor

kennedybaird commentedAug 13, 2024

Seed data - I think it's best if we just stop ignoring the example.db files
Honestly, I think this is a good approach. We do this already, and it's solid.
The primary downside I can see is the lack of human readability for the binary file on GitHub. We otherwise have theexamples/script example to showcase data seeding.

The intention was to still have the neededseed-data files, but have the database seeded for the first run