- Notifications
You must be signed in to change notification settings - Fork445
Create a testing environment in NodeJS and using modern JS syntax#28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
craigayre commentedFeb 19, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Can you also add .vscode/ and yarn.lock to your .gitignore? While I agree there should be ES6 examples (which is something I am also working on), I think they should be separated from the existing examples |
| ```javascript | ||
| var unsortedArray = [-10, 7, 29, 30, 5, -10, -70]; | ||
| const unsortedArray = [-10, 7, 29, 30, 5, -10, -70]; | ||
| computeProduct(unsortedArray); // 21000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This does not work since computeProduct is now not hoisted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'll fix that.
| @@ -10,35 +10,37 @@ | |||
| 1. [Javascript Specific](#javascript) | |||
| 1. To Be Continued | |||
| ## Want to Test Solutions ? | |||
| __[Demo and testing](demo)__ | |||
| - `npm install` or `yarn install` | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You could replaceyarn install with justyarn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Also, to be consistent withinstall, it might be worth adding how you test with yarn (yarn test)
The first change is just in array compute product.