- Notifications
You must be signed in to change notification settings - Fork1k
Android customizations#420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
TheBosZ wants to merge14 commits intokatzer:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Now the app can:-Set the channel name and description-Set the notification subtext-Add a "Close" action to the notification, along with customizing the action text and iconFixed bugs:-Icon is never used if it's in "drawable" rather than "mipmap"-Used "Compat" library to make backwards compatibility easier
Android notifications have a "how long ago was this notification set" timer.Now there's an option to turn that off (the default is true, so it's shown, matching current behavior).
I got the error message that "onactivate" does not exist with the latest HEAD Version. I therefore investigated and found out that since the on() function has been changed, I think this has been forgotten to also be changed in the Java file.
If you had two apps using this plugin running, clicking "Close" on a notification for one would close both.
Apply fix fromkatzer#419 (comment)
Remove Windows platcform from plugin.xml to allow install on cordova >9
| <config-filetarget="AndroidManifest.xml"parent="/manifest"> | ||
| <uses-permissionandroid:name="android.permission.WAKE_LOCK" /> | ||
| <uses-permissionandroid:name="android.permission.FOREGROUND_SERVICE" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please align those indents with the rest of the files (use spaces)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Now the app can:
-Set the channel name and description
-Set the notification subtext
-Add a "Close" action to the notification, along with customizing the action text and icon
-Disable the "time since the notification started" text
Fixed bugs:
-Icon is never used if it's in "drawable" rather than "mipmap"
-Used "Compat" library to make backwards compatibility easier