- Notifications
You must be signed in to change notification settings - Fork20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Downgrade Go version requirement to 1.20#17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
As part of the upgrade to Go 1.21, the Go toolchain now requires the`go` directive to match the maximum Go version in use in dependencies.This leads to any transitive dependency on this library to result in arequirement of the consuming project moving to Go 1.21.Although in a lot of cases this may not be as problematic, it forcesconsumers to migrate, which we don't need to do in this case.
This was referencedSep 4, 2023
kataras approved these changesSep 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I want users to be forced to upgrade their Go versions for security reasons but if that issues problems, we can downgrade to 1.20. Thanks
Thank you! 1.20 is still supported by the Go team so for now will be getting security updates too ☺ |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the upgrade to Go 1.21, the Go toolchain now requires the
godirective to match the maximum Go version in use in dependencies.This leads to any transitive dependency on this library to result in a
requirement of the consuming project moving to Go 1.21.
Although in a lot of cases this may not be as problematic, it forces
consumers to migrate, which we don't need to do in this case.
As discussed inoapi-codegen/oapi-codegen#1221 and related change ingofiber/fiber#2614. See alsogolang/go#62409