Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Protocol Rework#208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
midnightexigent wants to merge11 commits intokafka-rust:master
base:master
Choose a base branch
Loading
frommidnightexigent:protocol-rework

Conversation

midnightexigent
Copy link
Contributor

After reading through the protocol code, I thought it needed a bit of a rework - there is room for improvement (remove unsafe code, more idiomatic rust, and better performance)

I played around a bunch with alternative designs for better performance (notably for decoding) but it may be too complicated to adopt one of those approaches right now. Essentially, there should be custom read that allows to retrieve the bytes that are being read, which would minimize allocations and copies (seebincode).

For now I will try to implement something that works and that fully implements theprotocol using 0 unsafe code and idiomatic Rust, I will look into the customRead later on

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@midnightexigent

[8]ページ先頭

©2009-2025 Movatter.jp