Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
Fix watch mode for external extensions#9915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Webpack fixed this bug in a non-exported class that we keep made a"copy" of. I have included the fix in our copy of the class.This addresses an error causing wtach mode to fail to work whenusing it with external extensions (not in dev mode)
Thanks for making a pull request to JupyterLab! To try out this branch onbinder, follow this link: |
jasongrout approved these changesMar 9, 2021
Contributor
jasongrout left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! Looks good, thanks for tracking this down.
Contributor
jasongrout commentedMar 9, 2021
@meeseeksdev please backport to 3.0.x |
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull requestMar 9, 2021
blink1073 added a commit that referenced this pull requestMar 9, 2021
…5-on-3.0.xBackport PR#9915 on branch 3.0.x (Fix watch mode for external extensions)
This was referencedMar 15, 2021
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
bugstatus:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Issue found and opened in the Elyra repo:elyra-ai/elyra#1338
Bug fixed in webpack in commitwebpack/webpack@4d08446
Code changes
Webpack fixed this bug in a non-exported class,
FilterIgnoringWatchFileSystem, that we keep a"copy" of. I have included their fix in our copy of the class.
This addresses an error causing watch mode to fail to work when
using it with external extensions (not in dev mode), see the elyra issue for full stack trace