Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork3.8k
Let webpack automatically determine the required version of dependencies#8875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thanks for making a pull request to JupyterLab! To try out this branch onbinder, follow this link: |
blink1073 approved these changesAug 20, 2020
Contributor
blink1073 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
status:resolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Code changes
In some cases, like our federation example when we are testing itself and install the middle package into the md package as a local package on disk (so the dependency points to
../middle_package), we are passing in wrong version numbers to webpack because we blindly pull them from package.json, even if they aren't really version numbers, but paths.I think we should let webpack try to guess versions of dependencies. Withwebpack/webpack#11359, it will know to follow paths of local installs, for example.
User-facing changes
Backwards-incompatible changes